feat: add vim-style warning on exit with unsaved changes#122
Merged
agavra merged 1 commit intoagavra:mainfrom Jan 20, 2026
Merged
feat: add vim-style warning on exit with unsaved changes#122agavra merged 1 commit intoagavra:mainfrom
agavra merged 1 commit intoagavra:mainfrom
Conversation
- :q shows error when dirty, :q\! forces quit - Pressing q warns once, second q quits - Warning resets on other actions Closes agavra#61 Co-Authored-By: Claude Opus 4.5 <[email protected]>
agavra
approved these changes
Jan 20, 2026
Owner
agavra
left a comment
agavra
left a comment
There was a problem hiding this comment.
Looks great for your first rust contribution @mikecfisher - thanks for the fix! Also tested locally to make sure it works.
Contributor
Author
|
Thanks for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:qshows error "No write since last change (add ! to override)" when there are unsaved changes:q!forces quit regardless of dirty stateqin normal mode warns once ("Unsaved changes. Press q again to quit."), secondqquitsCloses #61
Test plan
q→ should show warningqagain → should quit:q→ should show error message:q!→ should quit immediately:w, pressq→ should quit without warning