feat(puppeteer): Cleanup node_modules #1497
Conversation
puppeteer/node-prune.sh
Outdated
| LICENCE | ||
| LICENCE-MIT | ||
| LICENCE.BSD | ||
| licence |
There was a problem hiding this comment.
I know that list is just copied, but can we legally delete such license files? maybe if there are identical, we can just run deduplication in rpm build?
There was a problem hiding this comment.
Oh, good point. As we already run the deduplication in RPM we could keep them. I'll check how much the size changes...
There was a problem hiding this comment.
With included license files the RPM size increased by about 24kB, so I'll rather keep them.
| MODULES_PATH="${1:-./node_modules}" | ||
|
|
||
| # delete Puppeteer CommonJS modules, we use the ES modules (in lib/esm) | ||
| rm -rf "$MODULES_PATH/puppeteer-core/lib/cjs" |
There was a problem hiding this comment.
I kind of expect that it will run internally that node-prune.sh..so just one command will be enough to cleanup pupeteer modules.
There was a problem hiding this comment.
Both commands are started in the agama-integration-test scripts which installs the NPM packages and runs the tests. Normally you should not need to run them separately.
| @@ -47,6 +47,12 @@ outside. | |||
| rm -f package-lock.json | |||
| local-npm-registry %{_sourcedir} install --omit=optional --with=dev --legacy-peer-deps || ( find ~/.npm/_logs -name '*-debug.log' -print0 | xargs -0 cat; false) | |||
|
|
|||
| # node_modules cleanup | |||
| %{_builddir}/agama/node-prune.sh | |||
There was a problem hiding this comment.
should we run it also for agama web directory?
There was a problem hiding this comment.
Agama-web uses webpack which already bundles only the needed files into the target JS file. It would not help there.
There was a problem hiding this comment.
And we do obfuscation and minification as well...
Prepare for releasing Agama 10· * #1263 * #1330 * #1407 * #1408 * #1410 * #1411 * #1412 * #1416 * #1417 * #1419 * #1420 * #1421 * #1422 * #1423 * #1424 * #1425 * #1428 * #1429 * #1430 * #1431 * #1432 * #1433 * #1436 * #1437 * #1438 * #1439 * #1440 * #1441 * #1443 * #1444 * #1445 * #1449 * #1450 * #1451 * #1452 * #1453 * #1454 * #1455 * #1456 * #1457 * #1459 * #1460 * #1462 * #1464 * #1465 * #1466 * #1467 * #1468 * #1469 * #1470 * #1471 * #1472 * #1473 * #1475 * #1476 * #1477 * #1478 * #1479 * #1480 * #1481 * #1482 * #1483 * #1484 * #1485 * #1486 * #1487 * #1488 * #1489 * #1491 * #1492 * #1493 * #1494 * #1496 * #1497 * #1498 * #1499 * #1500 * #1501 * #1502 * #1503 * #1504 * #1505 * #1506 * #1507 * #1508 * #1510 * #1511 * #1512 * #1513 * #1514 * #1515 * #1516 * #1517 * #1518 * #1519 * #1520 * #1522 * #1523 * #1524 * #1525 * #1526 * #1527 * #1528 * #1529 * #1530 * #1531 * #1532 * #1533 * #1534 * #1535 * #1536 * #1537 * #1540 * #1541 * #1543 * #1544 * #1545 * #1546 * #1547 * #1548 * #1549 * #1550 * #1552 * #1553 * #1554 * #1555 * #1556 * #1557 * #1558 * #1559 * #1560 * #1562 * #1563 * #1565 * #1566 * #1567 * #1568 * #1569 * #1570 * #1571 * #1572 * #1573 * #1574 * #1575 * #1576 * #1577 * #1578 * #1579 * #1580 * #1581 * #1583 * #1584 * #1585 * #1586 * #1587 * #1588 * #1589 * #1590 * #1591 * #1592 * #1593 * #1596 * #1597 * #1598 * #1600 * #1602 * #1605 * #1606 * #1607 * #1608 * #1610 * #1611 * #1612 * #1613 * #1614 * #1619 * #1620 * #1621
Problem
node_modulesdirectory is hugeSolution
node_modulesTesting
Numbers
node_modulesdirectory size went down from 39MB to 15MB (-62%)