Change WebVR references to WebXR#4982
Merged
dmarcos merged 1 commit intoaframevr:masterfrom Jan 12, 2022
jacob-willden:patch-1
Merged
Change WebVR references to WebXR#4982dmarcos merged 1 commit intoaframevr:masterfrom jacob-willden:patch-1
dmarcos merged 1 commit intoaframevr:masterfrom
jacob-willden:patch-1
Conversation
dmarcos
reviewed
Jan 5, 2022
| @@ -145,11 +145,11 @@ front-facing changes to A-Frame developers, involving mostly renaming of APIs. | |||
| - Chrome (WebXR under origin trials) | |||
| - Exokit (experimental early support) | |||
|
|
|||
| [webvrpolyfill]: https://github.com/googlevr/webvr-polyfill | |||
Member
There was a problem hiding this comment.
A-Frame still uses the WebVR polypill and no plans to migrate for now. We can revert this change
Member
|
Thanks just a couple of small changes and ready to merge |
Member
|
Thanks for the patience. I'm merging this and I'll replace the link to the WebVR polyfill. Congrats on your first contribution! 🥳 |
Contributor
Author
|
Great! Thank you so much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Updating the references to the deprecated WebVR API on the "VR Headsets & WebVR Browser page". Since the page URL includes the term WebVR, either keeping the old naming in the page title or creating a redirect may be needed.