Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore fails for concatenated strings in WP_DEBUG_LOG #10

Closed
noplanman opened this issue Nov 13, 2020 · 5 comments
Closed

Restore fails for concatenated strings in WP_DEBUG_LOG #10

noplanman opened this issue Nov 13, 2020 · 5 comments

Comments

@noplanman
Copy link

noplanman commented Nov 13, 2020 •
edited
Loading

As far as I can tell, the problem seems to be this line:

wp-debugging/src/Bootstrap.php

Line 200 in e18a678

$value = trim( $value, '"\'' ); // Normalize quoted value.

My wp-config.php before:

define( 'WP_DEBUG_LOG', __DIR__ . '/../logs/wp-debug.log' );

After restore (note the missing end quote of the file path):

define( 'WP_DEBUG_LOG', __DIR__ . '/../logs/wp-debug.log );
@afragen
Copy link
Owner

afragen commented Nov 14, 2020

You're right, but I don't really have a solution to adding a file path to WP_DEBUG_LOG. I know it works but I'm trying to sanitize my inputs.

May I suggest using ini_set( 'error_log', __DIR__ . '/../logs/wp-debug.log' ); instead.

@afragen
Copy link
Owner

afragen commented Nov 14, 2020

I'll see what I can do also.

@afragen
Copy link
Owner

afragen commented Nov 14, 2020

At this time I don't honestly know why I even added that line. Just comment it out. It will likely be commented out in the next release.

@noplanman
Copy link
Author

Was it maybe to prevent something like the quotes being saved in the string itself in some cases?

You can close off here after some more testing and when it's in the next release, thanks 🙏

@afragen
Copy link
Owner

afragen commented Nov 17, 2020

Release v2.9.1

@afragen afragen closed this as completed Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afragen @noplanman