Skip to content

Conversation

@costdev
Copy link

@costdev costdev commented Feb 5, 2024

Hello Dolly requires special handling as it is, by default, a single file plugin called hello.php. However, when installed via the Plugins Repository, it is placed in a nested directory called hello-dolly. The correct slug for Hello Dolly is therefore hello-dolly, not hello.

Recent commits to Plugin Dependencies added this special handling which exists elsewhere in Core which was manually tested.

This PR adds a PHPUnit unit to verify and protect the behaviour.

@github-actions
Copy link

github-actions bot commented Feb 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @[email protected].

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: .

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: [email protected].


To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@afragen afragen merged commit a915341 into afragen:dependencies-tab Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants