Skip to content

refactor: reduce METAR chunk decoder complexity#82

Merged
github-actions[bot] merged 0 commit into
mainfrom
feature/devin-20260712-sonar-complexidade-metar-chunks
Jul 12, 2026
Merged

refactor: reduce METAR chunk decoder complexity#82
github-actions[bot] merged 0 commit into
mainfrom
feature/devin-20260712-sonar-complexidade-metar-chunks

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
    • Reduced S3776 in CloudChunkDecoder, VisibilityChunkDecoder, RunwayVisualRangeChunkDecoder, and WindShearChunkDecoder by extracting parsing/validation helpers and keeping Parse() focused on orchestration.
  • Have you written new tests for your core changes, as applicable?
    • Existing chunk decoder tests cover the refactor paths; behavior was preserved.
  • Have you successfully ran tests with your changes locally?
    • dotnet build MetarDecoder.sln --configuration Release
    • dotnet test tests/Metar.Decoder.Tests/Metar.Decoder.Tests.csproj --configuration Release --framework net8.0 --collect:"XPlat Code Coverage"
    • dotnet test tests/Metar.Decoder.Tests/Metar.Decoder.Tests.csproj --configuration Release --framework net10.0 --collect:"XPlat Code Coverage"
    • dotnet test tests/Taf.Decoder.Tests/Taf.Decoder.Tests.csproj --configuration Release --framework net8.0 --collect:"XPlat Code Coverage"
    • dotnet test tests/Taf.Decoder.Tests/Taf.Decoder.Tests.csproj --configuration Release --framework net10.0 --collect:"XPlat Code Coverage"

Link to Devin session: https://app.devin.ai/sessions/a4e91bc6cd1447788a7bec8c00406d09


Open in Devin Review

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@afonsoft

Copy link
Copy Markdown
Owner

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@sonarqubecloud

Copy link
Copy Markdown

@github-actions
github-actions Bot merged commit 53aef17 into main Jul 12, 2026
19 of 22 checks passed
@github-actions

Copy link
Copy Markdown

Qodana Community for .NET

5 new problems were found

Inspection name Severity Problems
Possible 'System.NullReferenceException' 🔶 Warning 4
Possible 'System.InvalidOperationException' 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

Open in Devin Review

@afonsoft
afonsoft deleted the feature/devin-20260712-sonar-complexidade-metar-chunks branch July 12, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant