Skip to content

refactor: remove reflection dos testes de cobertura#105

Merged
github-actions[bot] merged 1 commit into
mainfrom
feature/devin-20260712-refactor-tests-internal
Jul 12, 2026
Merged

refactor: remove reflection dos testes de cobertura#105
github-actions[bot] merged 1 commit into
mainfrom
feature/devin-20260712-refactor-tests-internal

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Summary

Refatora os testes adicionados no PR #104 para eliminar System.Reflection.BindingFlags e tornar os métodos testados internal em vez de private.

Mudanças:

  • Adiciona <InternalsVisibleTo Include="..." /> em Metar.Decoder.csproj e Taf.Decoder.csproj
  • Torna internal os métodos:
    • MetarDecoder.ApplyDecodedData
    • TafDecoder.ApplyDecodedData
    • RunwayVisualRangeChunkDecoder.ToValue
    • EvolutionChunkDecoder.ParseEntitiesChunk, ApplyDecodedChunk, ResolveEntityName, HandleDecodeFailure, AddEvolution, InstantiateEntity
  • Substitui chamadas via reflection nos testes por invocações diretas

Motivação:
Evita acoplamento frágil a nomes de métodos privados e facilita manutenção futura.

Validação

  • dotnet build MetarDecoder.sln --configuration Release OK
  • dotnet test tests/Metar.Decoder.Tests/ net8.0/net10.0 — 244/244 passando
  • dotnet test tests/Taf.Decoder.Tests/ net8.0/net10.0 — 200/200 passando
  • Cobertura: 99,8% line, 99,5% branch

Link to Devin session: https://app.devin.ai/sessions/94a258020ea4488c8eecc672035d0da1
Requested by: @afonsoft

@afonsoft afonsoft self-assigned this Jul 12, 2026
@afonsoft
afonsoft self-requested a review July 12, 2026 22:42
@devin-ai-integration

devin-ai-integration Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@afonsoft

afonsoft commented Jul 12, 2026

Copy link
Copy Markdown
Owner

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@sonarqubecloud

sonarqubecloud Bot commented Jul 12, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
github-actions Bot merged commit 6f6bf9e into main Jul 12, 2026
17 of 19 checks passed
@github-actions

github-actions Bot commented Jul 12, 2026

Copy link
Copy Markdown

Qodana Community for .NET

10 new problems were found

Inspection name Severity Problems
Access to a static member of a type via a derived type 🔶 Warning 4
Local variable hides member 🔶 Warning 4
Member can be made private: Non-private accessibility ◽️ Notice 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@afonsoft
afonsoft deleted the feature/devin-20260712-refactor-tests-internal branch July 13, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afonsoft afonsoft Awaiting requested review from afonsoft

Assignees

@afonsoft afonsoft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@afonsoft