Repository navigation
refactor(style): make button spacing more proportional - #44
Conversation
| var margin = EdgeInsets.only( | ||
| top: widget.buttonMargin.top, | ||
| bottom: widget.buttonMargin.bottom, | ||
| left: widget.buttonMargin.left / 2, | ||
| right: widget.buttonMargin.right / 2, | ||
| ); | ||
|
|
There was a problem hiding this comment.
| var margin = EdgeInsets.only( | |
| top: widget.buttonMargin.top, | |
| bottom: widget.buttonMargin.bottom, | |
| left: widget.buttonMargin.left / 2, | |
| right: widget.buttonMargin.right / 2, | |
| ); | |
| EdgeInsets margin; |
|
Hey @ryanaidilp ! Thank you a lot for your contribution 🙏🏻 |
Thank you for your feedback! I've implemented the suggestions and bumped the version number to 1.3.7+2 in my recent push. Please feel free to review it when you get a chance. Let me know if there's anything else I can assist with. |
| name: buttons_tabbar | ||
| description: A Flutter package that implements a TabBar where each label is a toggle button. | ||
| version: 1.3.7+1 | ||
| version: 1.3.7+2 |
There was a problem hiding this comment.
Can you please update it to 1.3.8 please?
| # CHANGELOG | ||
|
|
||
|
|
||
| ## [1.3.7+2] - 16 October 2023 |
There was a problem hiding this comment.
Can you please update it to 1.3.8 please?
There was a problem hiding this comment.
Noted, on my way
|
Thank you a lot for your contribution @ryanaidilp !!! 🙇🏻 |
You're welcome! 😊 Thank you as well for creating this amazing package 👏👍 |
No problem at all. Btw, here's the link in pub.dev: |
Pull Request Description
In this pull request, I've undertaken a significant style enhancement focused on creating a more visually harmonious user interface. The issue at hand was the irregular spacing between buttons caused by direct padding implementation. Previously, when padding was directly applied using
EdgeInsets.all(16), it resulted in uneven distances between buttons, leading to an unbalanced layout:Before:
To rectify this, I've implemented a more precise logic to ensure proportional spacing between buttons. Through careful adjustments in the code, I've calculated margins dynamically based on the provided
widget.buttonMarginvalues and the position of the button. This meticulous approach results in a visually appealing and symmetrical button layout:After:
By applying these changes, the spacing between buttons is now not only consistent but also proportionate, creating a more polished and aesthetically pleasing user interface. This enhancement significantly improves the overall user experience and aligns the application's visual elements with modern design standards.