fix: preserve content after frontmatter in parse_instinct_file() by ericcai0814 · Pull Request #161 · affaan-m/everything-claude-code

ericcai0814 · 2026-02-06T07:37:49Z

Summary

parse_instinct_file() appended the instinct and reset state when frontmatter ended (---), before content lines could be collected — causing silent data loss of Action, Evidence, Examples sections during import.
Fix: only set in_frontmatter = False at frontmatter close; defer append to next frontmatter start or EOF, where the logic already exists.
Added pytest test covering multi-section instincts, single instinct, and empty content edge case.

Fixes #148

Reproduction

from parse_instinct_file import ...

content = """
---
id: test-1
trigger: "when coding"
confidence: 0.9
---

## Action
Always write tests first.

## Evidence
TDD improves quality.
"""

# Before fix: [{'id': 'test-1', 'content': ''}]
# After fix:  [{'id': 'test-1', 'content': '## Action\nAlways write tests first.\n\n## Evidence\nTDD improves quality.'}]

Test plan

pytest skills/continuous-learning-v2/scripts/test_parse_instinct.py -v — 3 passed
Manual verification with multi-instinct file — all content preserved
Empty content edge case — no error

Summary by CodeRabbit

Bug Fixes
- Improved frontmatter parsing to correctly handle instinct boundary processing and content finalization
Tests
- Added comprehensive unit tests for instinct parsing covering multiple instincts, single instinct, and empty content scenarios to ensure parsing reliability

parse_instinct_file() was appending the instinct and resetting state when frontmatter ended (second ---), before any content lines could be collected. This caused all content (Action, Evidence, Examples) to be lost during import. Fix: only set in_frontmatter=False when frontmatter ends. The existing logic at the start of next frontmatter (or EOF) correctly appends the instinct with its collected content. Fixes affaan-m#148

coderabbitai · 2026-02-06T07:38:09Z

📝 Walkthrough

Walkthrough

The changes fix a bug in the instinct file parser where content following frontmatter boundaries was lost during import. The parser now defers instinct finalization until the next frontmatter boundary or end-of-file, ensuring all content is preserved. Unit tests validate the fix across multiple scenarios.

Changes

Cohort / File(s)	Summary
Bug Fix `skills/continuous-learning-v2/scripts/instinct-cli.py`	Modified `parse_instinct_file()` to defer appending instincts until the next frontmatter boundary or EOF, rather than immediately when closing frontmatter is detected. This preserves content that follows the `---` delimiter.
Tests `skills/continuous-learning-v2/scripts/test_parse_instinct.py`	Added comprehensive unit tests validating `parse_instinct_file()` correctly preserves content across multiple instincts, single instincts, and empty content scenarios.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A parser's quest, oh what a tale,
Where frontmatter ends and content would pale,
But now with deference, 'til boundaries end,
Each instinct's wisdom flows without bend,
Tests verify this fix rings true and clear! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main fix: deferring content preservation in parse_instinct_file() to prevent loss of sections after frontmatter closure.
Linked Issues check	✅ Passed	The PR implementation directly addresses issue `#148` by deferring in_frontmatter state change to preserve post-frontmatter content during instinct file imports.
Out of Scope Changes check	✅ Passed	All changes are scoped to fixing the parse_instinct_file() function and adding corresponding unit tests; no unrelated modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

affaan-m

Approved

Excellent fix. Verified the parsing logic end-to-end:

Fix correctness

The state machine flow is now:

--- (start frontmatter) → append previous instinct if exists, reset state, in_frontmatter = True
YAML key:value lines → populate current dict
--- (end frontmatter) → in_frontmatter = False (fix: no longer appends here)
Content lines → collect into content_lines
Next --- → back to step 1, which appends with collected content
EOF → append final instinct with collected content

The bug was step 3 duplicating step 1's append logic, but before step 4 could run. Removing it is the correct fix.

Test quality

3 focused test cases covering multi-instinct, single instinct, and empty content
Smart use of importlib to handle the hyphenated filename
Assertions check for specific content strings, not just non-empty
Tests are self-contained with inline fixtures

PR quality

Minimal diff (-5 lines of logic)
Clear commit message with conventional format
Links to issue (#148)
Includes reproduction steps and before/after comparison

Well done @ericcai0814.

…aan-m#161) / parse_instinct_file() で frontmatter 後の content を保持

maurez83630-cmyk

github-recovery-codes.txt

ericcai0814 mentioned this pull request Feb 6, 2026

Bug: instinct-cli.py import loses content after frontmatter #148

Closed

affaan-m approved these changes Feb 6, 2026

View reviewed changes

affaan-m merged commit e4e94a7 into affaan-m:main Feb 6, 2026
2 checks passed

524y added a commit to 524y/everything-claude-code-japanese that referenced this pull request Feb 7, 2026

fix: preserve content after frontmatter in parse_instinct_file() (aff…

2df7c04

…aan-m#161) / parse_instinct_file() で frontmatter 後の content を保持

maurez83630-cmyk reviewed Feb 9, 2026

View reviewed changes

This was referenced Feb 13, 2026

feat: add project-scoped instinct isolation #218

Open

fix: use CLI argument for hook phase detection in observe.sh #242

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: preserve content after frontmatter in parse_instinct_file()#161

fix: preserve content after frontmatter in parse_instinct_file()#161
affaan-m merged 1 commit intoaffaan-m:mainfrom
ericcai0814:fix/instinct-import-content-loss

ericcai0814 commented Feb 6, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 6, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

affaan-m left a comment

Uh oh!

Uh oh!

maurez83630-cmyk left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Uh oh!

Conversation

ericcai0814 commented Feb 6, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Reproduction

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

affaan-m left a comment

Choose a reason for hiding this comment

Approved

Fix correctness

Test quality

PR quality

Uh oh!

Uh oh!

maurez83630-cmyk left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

ericcai0814 commented Feb 6, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 6, 2026 •

edited

Loading