Make db_direct_access the default #4129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dincho
reviewed
May 2, 2023
apps/aecore/src/aec_db.erl
Outdated
| {ok, true} -> | ||
| case AllStandalone of | ||
| [] -> | ||
| lager:debug("Enabling direct access for rocksdb", []), |
Member
There was a problem hiding this comment.
INFO would be more appropriate IMO
Member
|
A release note is somehow important for this change IMO, although it is BC |
seanhinde
previously approved these changes
May 29, 2023
dincho
previously approved these changes
May 29, 2023
uwiger
force-pushed
the
gh3088-make-direct-access-default
branch
from
ac82a82 to
51dd269
Compare
hanssv
approved these changes
May 22, 2024
dincho
added
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #3088
The most (only?) robust way to avoid database corruption during IO saturation is to run with the
db_direct_accesssetting. This makes the rocksdb plugin use rocksdb transactions rather than mnesia transactions. This ensures atomicity in the case when writes are rejected due to congestion.This is an initial push, partly to ensure that we don't forget to make this the detault.