[Java] Support camelCase enum type identifiers for value refs#963
Merged
mjpt777 merged 1 commit intoaeron-io:masterfrom Nov 28, 2023
Merged
[Java] Support camelCase enum type identifiers for value refs#963mjpt777 merged 1 commit intoaeron-io:masterfrom
mjpt777 merged 1 commit intoaeron-io:masterfrom
Conversation
Contributor
|
Please provide more detail as this would be a breaking change for existing code. |
The type identifier was previously used as-is (e.g. `carFilterType`) in the generated code for uses of `valueRef` while generated Java enums always start with a capital letter (`CarFilterType`). See the added test in ValueRefWithLowerCaseEnum.java.
pliard
force-pushed
the
fix-java-enum-case
branch
from
b05dcfd to
0a96b2f
Compare
Contributor
Author
Thanks for the quick reply. Please take another look. I've added a test to show the issue. |
mjpt777
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type identifier was previously used as-is (e.g.
carFilterType) inthe generated code for uses of
valueRefwhile generated Java enumsalways start with a capital letter (
CarFilterType).See the added test in
ValueRefWithLowerCaseEnum.java.