Skip to content

[C#] Add ToString#853

Merged
mjpt777 merged 14 commits intoaeron-io:masterfrom
MarketFactory:add_csharp_tostring
Jun 4, 2021
Merged

[C#] Add ToString#853
mjpt777 merged 14 commits intoaeron-io:masterfrom
MarketFactory:add_csharp_tostring

Conversation

@MFrpurdy
Copy link
Contributor

@MFrpurdy MFrpurdy commented Jun 3, 2021

#852

  • Added ToString generation methods.
  • In testing these changes user rca22 discovered that data types without encodings - for raw data - were not working correctly. The ToString would not work and the newly added Get/Set to/from String methods would also not work. Fixed.

Example:

[Car](sbeTemplateId=1|sbeSchemaId=1|sbeSchemaVersion=0|sbeBlockLength=45):SerialNumber=1234|ModelYear=2013|Available=T|Code=A|SomeNumbers=[0,1,2,3]|VehicleCode=abcdef|Extras={SportsPack, CruiseControl}|DiscountedModel=C|Engine=(Capacity=2000|NumCylinders=4|MaxRpm=9000|ManufacturerCode=123|Fuel=Petrol|Efficiency=35|BoosterEnabled=T|Booster=(BoostType=NITROUS|HorsePower=200))|FuelFigures=[(Speed=30|Mpg=35.9|UsageDescription='Urban Cycle'),(Speed=55|Mpg=49|UsageDescription='Combined Cycle'),(Speed=75|Mpg=40|UsageDescription='Highway Cycle')]|PerformanceFigures=[(OctaneRating=95|Acceleration=[(Mph=30|Seconds=4),(Mph=60|Seconds=7.5),(Mph=100|Seconds=12.2)]),(OctaneRating=99|Acceleration=[(Mph=30|Seconds=3.8),(Mph=60|Seconds=7.1),(Mph=100|Seconds=11.8)])]|Manufacturer='Honda'|Model='Civic VTi'|ActivationCode='abcdef'

Rob Purdy and others added 13 commits May 5, 2021 21:53
[C#] Add more string reading/writing methods to DirectBuffer
27b9188 
More, hopefully efficient, mechanisms to read and write strings to and from the DirectBuffer.
[C#] Reverted to .net45
1a8e321
@MFrpurdy
Merge branch 'real-logic:master' into master
6cc75dc
[C#] Reverted to .net45
2b494b0
Merge branch 'master' of https://github.com/MarketFactory/simple-bina…
047cdc2 
…ry-encoding
[C#] Updated Samples to use the new String methods
262d2a3
[C#] Fixed checkstyle
5f54a0d
[C#] Cleaning
76bf8b6
Added Modified Benchmarks\nBoth a modified version of the the CarBenc…
0143183 
…hmark which encodes and decodes to/from string; and a version wich uses the new methods to encode and decode strings
Merge remote-tracking branch 'upstream/master'
50f7dc3
Added ToString
9af8807
Added support for contant tokens
5d10e99
Fixed issue with ToString of tokens without an encoding - like raw da…
a8bf7bc 
…ta fields
mjpt777
mjpt777 reviewed Jun 3, 2021
View reviewed changes
sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/csharp/CSharpGenerator.java
case BEGIN_COMPOSITE:
{
append(sb, indent, "if (this." + fieldName + " != null)");
append(sb, indent, " this." + fieldName + ".BuildString(builder);");
Copy link
Contributor

@mjpt777 mjpt777 Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocks without braces is not good practice and easy to introduce bugs with.

Copy link
Contributor Author

@MFrpurdy MFrpurdy Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I also saw an small indenting issue which I fixed.

@mjpt777
Copy link
Contributor

mjpt777 commented Jun 3, 2021

Looks good. If you fix the generated code to always put code blocks in curly brackets then I'll merge.

@mjpt777 mjpt777 merged commit 91aabea into aeron-io:master Jun 4, 2021
mjpt777 added a commit that referenced this pull request Jun 4, 2021
@mjpt777
[Java] Fix formatting after merge of PR #853.
5eee462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjpt777 mjpt777 mjpt777 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MFrpurdy @mjpt777