[Go] Fix tokens passed to generateComposite (#849)#850
Merged
mjpt777 merged 2 commits intoaeron-io:masterfrom May 14, 2021
Merged
[Go] Fix tokens passed to generateComposite (#849)#850mjpt777 merged 2 commits intoaeron-io:masterfrom
mjpt777 merged 2 commits intoaeron-io:masterfrom
Conversation
Too many tokens were passed to `generateComposite` causing weird errors like(aeron-io#844 and aeron-io#849).
The `Decode` generator for groups would produce the following code:
```
for i, _ := range o.GroupName {
```
The `gofmt` tools suggest [simplify range expression](https://github.com/golang/tools/blob/master/internal/lsp/analysis/simplifyrange/simplifyrange.go#L23):
```
A range of the form:
for x, _ = range v {...}
will be simplified to:
for x = range v {...}
```
This patch fixes that.
Contributor
|
That check failure looks transient? This looks like a good fix to a clear bug in handling. And it's always great to get a regression test case with the PR. |
Contributor
Author
|
Yes, it looks like that one CI job failed with “502 bad gateway”, some network hiccup during setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Too many tokens were passed to
generateCompositecausing weirderrors like(#844 and #849).
Also adds a
gofmtfix.