[C#] Fix repeated group buffer overflow#823
Merged
mjpt777 merged 1 commit intoaeron-io:masterfrom Nov 26, 2020
j4b6ski:patch-1
Merged
[C#] Fix repeated group buffer overflow#823mjpt777 merged 1 commit intoaeron-io:masterfrom j4b6ski:patch-1
mjpt777 merged 1 commit intoaeron-io:masterfrom
j4b6ski:patch-1
Conversation
On a repeated group in the WrapForEncode, the parentMessage.Limit has two purposes: 1. It is used as a buffer offset for the _dimensions helper Wrap method 2. The assignment to it has a side effect of checking that we do not exceed the underlying DirectBuffer's capacity However notice that currently this assignment happens after writing to the _dimensions helper properties BlockLength and NumInGroup, i.e. the writes are done *before* we check for buffer overflow. Underneath these are direct writes to the byte* managed by the DirectBuffer, resulting in an unchecked, unsafe buffer overflow. To fix this the Limit has to be increased right after the call to the _dimensions.Wrap, before writes to BlockLength and NumInGroup The same occurs in the Decode method, only reading unsafe, invalid memory instead of writing to it. Also fixed _actingVersion was being used before it's assigned in the Encode
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This actually broke code I was working on in a very nasty way when the buffer size was too small - I was trying to use the DirectBuffer's bufferOverflow delegate and some bytes were getting eaten when expanding the buffer.
Explanation in the commit msg:
On a repeated group in the WrapForEncode, the parentMessage.Limit has two purposes:
However notice that currently this assignment happens after writing to the _dimensions helper properties BlockLength and NumInGroup,
i.e. the writes are done before we check for buffer overflow.
Underneath these are direct writes to the byte* managed by the DirectBuffer, resulting in an unchecked, unsafe buffer overflow.
To fix this the Limit has to be increased right after the call to the _dimensions.Wrap, before writes to BlockLength and NumInGroup
The same occurs in the Decode method, only reading unsafe, invalid memory instead of writing to it.
Also fixed _actingVersion was being used before it's assigned in the Encode