C# auto-generated header for generated c# codec files#814
Merged
mjpt777 merged 2 commits intoaeron-io:masterfrom Sep 15, 2020
Merged
C# auto-generated header for generated c# codec files#814mjpt777 merged 2 commits intoaeron-io:masterfrom
mjpt777 merged 2 commits intoaeron-io:masterfrom
Conversation
Contributor
|
@billsegall Do you have a view on this? |
Contributor
|
I can see it makes sense but I have no experience on the usage of .g.cs.
This pull request seems not to change .gitignore files ot VS projects. Is
it complete?
I won't get any time to look further until next week,
Bill.
…On Tue, 25 Aug 2020 at 18:09, Martin Thompson ***@***.***> wrote:
@billsegall <https://github.com/billsegall> Do you have a view on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#814 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJDLJGIBZ2UN57M3SPPMXDSCNWSRANCNFSM4QJP7R6A>
.
|
Contributor
|
Please ensure the build passes all tests before submitting. |
…e top of each generated C# file. Auto-generated files are not included in automatic code-cleanup and/or inspection processes.
Like the auto-generated tag in the file's header, this causes files to be recognized as auto-generated code by Visual Studio. An added bonus of the filename change is that these files can be treated differently based on the filename in your project's .gitignore or .editorconfig files
mhoogveld
force-pushed
the
csharp-autogenerated-header
branch
from
553c40a to
09d1811
Compare
Contributor
Author
|
@billsegall I'm not sure what .gitignore file(s) you refer to. @mjpt777 If I'm correct, the failing test already fails in the commit in the master on which this branch is based. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the header to generated .cs files will cause them to be ignored by Visual Studio's code-inspection, which will speed up the IDE.
Also changed to file-extension from *.cs to *.g.cs, which has exactly the same result in Visual Studio, but can also be used by other tools (e.g. Git's .gitignore or Visual Studio's .editorconfig)
The *.g.cs extension is mentioned in various places and is used since VS 2008 or earlier, but there does not seem to be any official documentation.
The best reference I found regarding the extension is https://developers.google.com/protocol-buffers/docs/reference/csharp-generated