[C++] Methods to calculate the length of an SBE message#761
Merged
tmontgomery merged 9 commits intoaeron-io:masterfrom Mar 18, 2020
Merged
[C++] Methods to calculate the length of an SBE message#761tmontgomery merged 9 commits intoaeron-io:masterfrom
tmontgomery merged 9 commits intoaeron-io:masterfrom
Conversation
agmt
force-pushed
the
master
branch
2 times, most recently
from
e04fe8c to
693c052
Compare
|
This pull request introduces 1 alert when merging 693c052 into 6ec0439 - view on LGTM.com new alerts:
|
Contributor
|
Will look in more detail in at a later date. Got a bit too much on at the minute. One thing on naming. Something that will calculate the total so be named to reflect that it is not a simple accessor. Something like |
Contributor
Author
|
@mjpt777 noticed. New function names are: |
Contributor
|
I see you were fixing some warnings in addition to this. I've picked those up independently. |
added 9 commits
March 10, 2020 15:47
Contributor
Author
|
I've rebased on master |
Contributor
|
Be good to get @tmontgomery view on this. |
mjpt777
added a commit
that referenced
this pull request
Mar 19, 2020
mjpt777
added a commit
that referenced
this pull request
Mar 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements: #291