Rust codec improvements - handle offsets, custom group size encoding#679
Merged
mjpt777 merged 12 commits intoaeron-io:masterfrom May 7, 2019
Merged
Rust codec improvements - handle offsets, custom group size encoding#679mjpt777 merged 12 commits intoaeron-io:masterfrom
mjpt777 merged 12 commits intoaeron-io:masterfrom
Conversation
added 12 commits
May 6, 2019 17:02
Fails on non-standard message header as it's currently generated separately.
Without a default value, structs with paddings become tedious to construct.
mjpt777
added a commit
that referenced
this pull request
May 7, 2019
agmt
pushed a commit
to agmt/simple-binary-encoding
that referenced
this pull request
May 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a few issues with the Rust codec. Decoders can now handle messages with custom offsets, custom default message header and custom group size encodings. Custom group size is not yet implemented for encoders.
There are also no tests for Rust which would exercise the full encode -> decode cycle. Hopefully I'll get to that and improving encoders when I need to do encoding.