Merged
Conversation
Niko-Klaiber
force-pushed
the
add_c_generator
branch
2 times, most recently
from
b4f60ba to
d7f3838
Compare
Contributor
|
will do a thorough review in the near future. |
Contributor
|
Made some major changes to the C++ generator (such as removing sbe.h) that might be good to review and see if they affect this. |
Niko-Klaiber
force-pushed
the
add_c_generator
branch
from
d7f3838 to
82fb753
Compare
Contributor
Author
|
Hello tmontgomery, I applied the most recent changes to my file. |
Niko-Kaneko
force-pushed
the
add_c_generator
branch
from
9842673 to
4752d5b
Compare
Niko-Kaneko
force-pushed
the
add_c_generator
branch
from
4752d5b to
70b0418
Compare
Contributor
|
Sorry it took a while to get to a proper review. This looks pretty good. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does not support OTF decoding for C. I converted the tests for C++ that do not involve OTF decoding to use the stubs generated for C.