Generate noChoicesSet convenience method for Sets#575
Merged
mjpt777 merged 2 commits intoaeron-io:masterfrom Jul 28, 2018
Merged
Generate noChoicesSet convenience method for Sets#575mjpt777 merged 2 commits intoaeron-io:masterfrom
mjpt777 merged 2 commits intoaeron-io:masterfrom
Conversation
Contributor
|
This could be a useful feature. Would make sense to call it something more like |
mjpt777
added a commit
that referenced
this pull request
Jul 28, 2018
Contributor
|
Please run the full build to ensure it passes. |
Contributor
Author
|
Woops - fixed now. |
mjpt777
added a commit
that referenced
this pull request
Jul 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The decoder generated for a Set does not provide a convenience method to determine if nothing has been set. If we look at sbe_samples and Car's OptionalExtras, the only way to determine if no OptionalExtras
have been set is to call
And this code is fragile and inefficient. This PR modifies SbeTool to generate a new method in OptionalExtrasDecoder