[Java] Invalid code generated for newly added string field#574
Merged
mjpt777 merged 1 commit intoaeron-io:masterfrom Jul 19, 2018
Merged
Conversation
If a schema is extended to include a new string field (fixed or variable), the newly generated decoder code not compile due to an error for deserialising the string using appendable; if the "sinceVersion" and "actingVersion" don't line up it tries to return a string on a void method. This commit changes the generated code to just call "return;"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a schema is extended to include a new string field (fixed or variable), the newly generated decoder code not compile due to an error for deserialising the string using appendable; if the "sinceVersion" and "actingVersion" don't line up it tries to return a string on a void method. This commit changes the generated code to just call "return;"