ostree-kernel-initramfs: add back initramfs fit workaround#777
Merged
pattivacek merged 1 commit intoadvancedtelematic:masterfrom Oct 16, 2020
Merged
ostree-kernel-initramfs: add back initramfs fit workaround#777pattivacek merged 1 commit intoadvancedtelematic:masterfrom
pattivacek merged 1 commit intoadvancedtelematic:masterfrom
Conversation
Previous initramfs fit specific workaround was removed as part of commit 6eecf15, causing ostree to provide an init argument as part of the kernel command line arguments when it is not really needed. Bring back the workaround by simply generating an empty file in case kernel image type is fit and initramfs is also used by the target. Signed-off-by: Ricardo Salveti <[email protected]>
Contributor
Author
|
@liuming50 something I noticed when updating to latest meta-updater. |
ricardosalveti
added a commit
to ricardosalveti/meta-lmp
that referenced
this pull request
Oct 15, 2020
Changes proposed to meta-updater at: advancedtelematic/meta-updater#777 Signed-off-by: Ricardo Salveti <[email protected]>
ricardosalveti
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Oct 15, 2020
Changes proposed to meta-updater at: advancedtelematic/meta-updater#777 Signed-off-by: Ricardo Salveti <[email protected]>
pattivacek
approved these changes
Oct 16, 2020
Collaborator
pattivacek
left a comment
pattivacek
left a comment
There was a problem hiding this comment.
I also wondered about that bit being removed. It looks correct to me to restore it. Some of the tests failed, but they are known to fail at present on master and they aren't particularly relevant to your changes. Thanks!
ricardosalveti
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Jan 7, 2022
Changes proposed to meta-updater at: advancedtelematic/meta-updater#777 Signed-off-by: Ricardo Salveti <[email protected]> (cherry picked from commit dca95a7) Signed-off-by: Raul Muñoz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous initramfs fit specific workaround was removed as part of commit
6eecf15, causing ostree to provide an init argument as part of the
kernel command line arguments when it is not really needed.
Bring back the workaround by simply generating an empty file in case
kernel image type is fit and initramfs is also used by the target.
Signed-off-by: Ricardo Salveti [email protected]