Repository navigation
Commit 9adc368
deps: V8: backport b69a1a1d8613
Original commit message:
[regexp] Record flags on deferred worklist items
ActionNode::Emit for MODIFY_FLAGS was previously changed to restore
outer_flags on the way out to avoid leaking inner flags to trailing
deferred nodes. However, this caused nodes deferred from within the
modifier group to be compiled with the outer flags when processed by
Compiler::Assemble.
Instead of restoring flags in ActionNode::Emit, record the active flags
at the point where a node is deferred in Compiler::AddWork, and restore
them from the work-list item before emitting it.
This partially reverts
https://chromium-review.googlesource.com/c/v8/v8/+/8174589.
Change-Id: I3a552f9223b88ba99889e4375b8d1ea761257b94
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8213283
Reviewed-by: Patrick Thier <[email protected]>
Auto-Submit: Jakob Linke <[email protected]>
Commit-Queue: Patrick Thier <[email protected]>
Cr-Commit-Position: refs/heads/main@{#109102}
Refs: v8/v8@b69a1a1
Co-authored-by: Radu Samson <[email protected]>
Refs: nodejs#66277
PR-URL: nodejs#67207
Reviewed-by: Antoine du Hamel <[email protected]>1 parent c54a21b commit 9adc368
4 files changed
Lines changed: 26 additions & 5 deletions
File tree
- deps/v8
- src/regexp
- test/mjsunit
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
346 | 346 | | |
347 | 347 | | |
348 | 348 | | |
349 | | - | |
| 349 | + | |
350 | 350 | | |
351 | 351 | | |
352 | 352 | | |
| |||
357 | 357 | | |
358 | 358 | | |
359 | 359 | | |
360 | | - | |
| 360 | + | |
| 361 | + | |
361 | 362 | | |
362 | 363 | | |
363 | 364 | | |
364 | 365 | | |
| 366 | + | |
365 | 367 | | |
366 | 368 | | |
367 | 369 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
570 | 570 | | |
571 | 571 | | |
572 | 572 | | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
573 | 578 | | |
574 | 579 | | |
575 | 580 | | |
576 | | - | |
| 581 | + | |
577 | 582 | | |
578 | 583 | | |
579 | 584 | | |
| |||
644 | 649 | | |
645 | 650 | | |
646 | 651 | | |
647 | | - | |
| 652 | + | |
648 | 653 | | |
649 | 654 | | |
650 | 655 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
0 commit comments