Skip to content

Commit 45314fc

Browse files
fix(desktop): preserve first huddle speech (block#3962)
## Context On the first huddle after launching Buzz Desktop, a live agent reply can arrive after agent membership is known but before the initial TTS-enabled state has loaded. The subscription previously released buffered messages at the membership boundary, so that first reply was evaluated while speech was still disabled and was silently skipped. Later replies worked, and later huddles usually worked because the state was already warm. ## Summary Hold initial live agent replies until both authoritative agent membership and the initial TTS state are known. This preserves the first eligible reply after a cold app launch without changing live-only routing, ordering, or fail-closed behavior. ## Changes - Replace the membership-only startup gate with a two-signal readiness gate for membership and TTS state. - Release buffered live messages in arrival order only after both signals resolve. - Drop buffered messages if either initial lookup fails. - Add a deterministic regression for the observed ordering: membership resolves first, TTS enables second, and the first reply is spoken. ## Related issue None found. ## Testing Manual validation in the daily-driver build confirmed that the first agent reply is spoken in the first huddle after a fresh app launch. The regression scenario was also run against both revisions: ```text main: FAIL — actual spoken replies: []; expected: ["first agent reply"] PR: PASS — 10 passed, 0 failed ``` ## Screenshots N/A, nonvisual speech behavior. ## Reviewer-reproducible examples 1. Quit Buzz Desktop completely. 2. Reopen it with Pocket TTS enabled. 3. Start the first huddle of the session with a running agent. 4. Send a prompt that produces a spoken agent reply immediately after the huddle starts. 5. Confirm the first reply is spoken, not only the second reply. 6. Stop the huddle, start another one, and confirm subsequent huddles retain the same behavior. For a deterministic red/green check, run the same membership-before-TTS-state ordering from `desktop/`. On `main`: ```bash node --import ./test-loader.mjs --experimental-strip-types --input-type=module -e ' import assert from "node:assert/strict"; import { createInitialMembershipGate, createOrderedSpeaker } from "./src/features/huddle/lib/ttsLiveMessages.ts"; const spoken = []; const speaker = createOrderedSpeaker(async text => spoken.push(text), error => { throw error; }, false); const gate = createInitialMembershipGate(text => speaker.enqueue(text, 1)); gate.push("first agent reply"); gate.succeed(); speaker.setEnabled(true); await new Promise(resolve => setTimeout(resolve, 0)); console.log("spoken:", JSON.stringify(spoken)); assert.deepEqual(spoken, ["first agent reply"]); ' ``` Observed failure: ```text spoken: [] AssertionError: Expected values to be strictly deep-equal ``` On this PR branch: ```bash node --import ./test-loader.mjs --experimental-strip-types --input-type=module -e ' import assert from "node:assert/strict"; import { createInitialTtsReadinessGate, createOrderedSpeaker } from "./src/features/huddle/lib/ttsLiveMessages.ts"; const spoken = []; const speaker = createOrderedSpeaker(async text => spoken.push(text), error => { throw error; }, false); const gate = createInitialTtsReadinessGate(text => speaker.enqueue(text, 1)); gate.push("first agent reply"); gate.markMembershipKnown(); speaker.setEnabled(true); gate.markTtsStateKnown(); await new Promise(resolve => setTimeout(resolve, 0)); console.log("spoken:", JSON.stringify(spoken)); assert.deepEqual(spoken, ["first agent reply"]); ' ``` Observed output: ```text spoken: ["first agent reply"] ``` --------- Signed-off-by: John Tennant <[email protected]>
1 parent eb049dd commit 45314fc

3 files changed

Lines changed: 74 additions & 31 deletions

File tree

‎desktop/src/features/huddle/lib/ttsLiveMessages.test.mjs‎

Lines changed: 33 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import test from "node:test";
33

44
import {
55
classifySpeakableAgentText,
6-
createInitialMembershipGate,
6+
createInitialTtsReadinessGate,
77
createLatestStateGate,
88
createOrderedSpeaker,
99
routeLiveAgentText,
@@ -221,27 +221,51 @@ test("a live TTS state event supersedes a delayed bootstrap result", () => {
221221
assert.deepEqual(applied, [false]);
222222
});
223223

224-
test("buffers initial live events until membership resolves in order", () => {
224+
test("buffers initial live events until membership and TTS state resolve", () => {
225225
const delivered = [];
226-
const gate = createInitialMembershipGate((event) => delivered.push(event));
226+
const gate = createInitialTtsReadinessGate((event) => delivered.push(event));
227227
gate.push("first");
228228
gate.push("second");
229229
assert.deepEqual(delivered, []);
230-
gate.succeed();
230+
gate.markMembershipKnown();
231+
assert.deepEqual(delivered, []);
232+
gate.markTtsStateKnown();
231233
gate.push("third");
232234
assert.deepEqual(delivered, ["first", "second", "third"]);
233235
});
234236

235-
test("drops the initial buffer fail-closed when membership lookup fails", () => {
237+
test("preserves the first agent reply when membership resolves before TTS state", async () => {
238+
const spoken = [];
239+
const speaker = createOrderedSpeaker(
240+
async (text) => spoken.push(text),
241+
assert.fail,
242+
false,
243+
);
244+
const gate = createInitialTtsReadinessGate((text) =>
245+
speaker.enqueue(text, 1),
246+
);
247+
248+
gate.push("first agent reply");
249+
gate.markMembershipKnown();
250+
speaker.setEnabled(true);
251+
gate.markTtsStateKnown();
252+
await new Promise((resolve) => setTimeout(resolve, 0));
253+
254+
assert.deepEqual(spoken, ["first agent reply"]);
255+
});
256+
257+
test("drops the initial buffer fail-closed with the readiness failure", () => {
236258
const delivered = [];
237259
const dropped = [];
238-
const gate = createInitialMembershipGate(
260+
const gate = createInitialTtsReadinessGate(
239261
(event) => delivered.push(event),
240-
(event) => dropped.push(event),
262+
(event, reason) => dropped.push({ event, reason }),
241263
);
242264
gate.push("unverified");
243-
gate.fail();
265+
gate.fail("tts_state_unavailable");
244266
gate.push("after-failure");
245267
assert.deepEqual(delivered, ["after-failure"]);
246-
assert.deepEqual(dropped, ["unverified"]);
268+
assert.deepEqual(dropped, [
269+
{ event: "unverified", reason: "tts_state_unavailable" },
270+
]);
247271
});

‎desktop/src/features/huddle/lib/ttsLiveMessages.ts‎

Lines changed: 28 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -152,34 +152,49 @@ export function createLatestStateGate<T>(apply: (value: T) => void): {
152152
};
153153
}
154154

155-
/** Hold live events until the first authoritative agent-membership lookup. */
156-
export function createInitialMembershipGate<T>(
155+
/** Hold live events until initial membership and TTS state are both known. */
156+
export function createInitialTtsReadinessGate<T>(
157157
deliver: (event: T) => void,
158-
drop: (event: T) => void = () => {},
158+
drop: (
159+
event: T,
160+
reason: "membership_unavailable" | "tts_state_unavailable",
161+
) => void = () => {},
159162
): {
160163
push: (event: T) => void;
161-
succeed: () => void;
162-
fail: () => void;
164+
markMembershipKnown: () => void;
165+
markTtsStateKnown: () => void;
166+
fail: (reason: "membership_unavailable" | "tts_state_unavailable") => void;
163167
} {
164168
let settled = false;
169+
let membershipKnown = false;
170+
let ttsStateKnown = false;
165171
let pending: T[] = [];
172+
const releaseIfReady = () => {
173+
if (settled || !membershipKnown || !ttsStateKnown) return;
174+
settled = true;
175+
const buffered = pending;
176+
pending = [];
177+
for (const event of buffered) deliver(event);
178+
};
166179
return {
167180
push(event) {
168181
if (settled) deliver(event);
169182
else pending.push(event);
170183
},
171-
succeed() {
172-
if (settled) return;
173-
settled = true;
174-
const buffered = pending;
175-
pending = [];
176-
for (const event of buffered) deliver(event);
184+
markMembershipKnown() {
185+
membershipKnown = true;
186+
releaseIfReady();
187+
},
188+
markTtsStateKnown() {
189+
ttsStateKnown = true;
190+
releaseIfReady();
177191
},
178-
fail() {
192+
fail(reason) {
193+
if (settled) return;
179194
settled = true;
180195
const dropped = pending;
181196
pending = [];
182-
for (const event of dropped) drop(event);
197+
for (const event of dropped) drop(event, reason);
183198
},
184199
};
185200
}

‎desktop/src/features/huddle/lib/useTtsSubscription.ts‎

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import * as React from "react";
55
import { buildHuddleTtsLiveFilter } from "@/shared/api/relayChannelFilters";
66
import { relayClient } from "@/shared/api/relayClient";
77
import {
8-
createInitialMembershipGate,
8+
createInitialTtsReadinessGate,
99
createLatestStateGate,
1010
createOrderedSpeaker,
1111
routeLiveAgentText,
@@ -114,11 +114,11 @@ export function useTtsSubscription(
114114
);
115115
}
116116
};
117-
const initialMembershipGate = createInitialMembershipGate(
117+
const initialReadinessGate = createInitialTtsReadinessGate(
118118
deliver,
119-
({ routeId }) => {
119+
({ routeId }, reason) => {
120120
console.debug(
121-
`[huddle] tts stage=eligibility status=rejected reason=membership_unavailable route_id=${routeId}`,
121+
`[huddle] tts stage=eligibility status=rejected reason=${reason} route_id=${routeId}`,
122122
);
123123
},
124124
);
@@ -131,7 +131,7 @@ export function useTtsSubscription(
131131
for (const pk of pubkeys) agentPubkeys.add(pk);
132132
agentsLoaded = true;
133133
if (initial) {
134-
initialMembershipGate.succeed();
134+
initialReadinessGate.markMembershipKnown();
135135
}
136136
} catch (e) {
137137
// Fail-closed on ALL failures, including refresh after prior success.
@@ -140,7 +140,7 @@ export function useTtsSubscription(
140140
agentPubkeys.clear();
141141
agentsLoaded = false;
142142
if (initial) {
143-
initialMembershipGate.fail();
143+
initialReadinessGate.fail("membership_unavailable");
144144
}
145145
console.error("[huddle] Failed to load agent pubkeys:", e);
146146
}
@@ -159,6 +159,7 @@ export function useTtsSubscription(
159159
if (!disposed) {
160160
ttsStateKnown = true;
161161
speakInOrder.setEnabled(state.tts_enabled);
162+
initialReadinessGate.markTtsStateKnown();
162163
}
163164
},
164165
);
@@ -177,11 +178,14 @@ export function useTtsSubscription(
177178
if (!disposed) applyBootstrap(state);
178179
})
179180
.catch((err) => {
181+
if (!ttsStateKnown)
182+
initialReadinessGate.fail("tts_state_unavailable");
180183
console.warn("[huddle] Failed to load TTS state:", err);
181184
});
182185
})
183186
.catch((err) => {
184187
speakInOrder.setEnabled(false);
188+
initialReadinessGate.fail("tts_state_unavailable");
185189
console.warn("[huddle] Failed to listen for TTS state:", err);
186190
});
187191

@@ -204,15 +208,15 @@ export function useTtsSubscription(
204208
if (oldest !== undefined) seenEventIds.delete(oldest);
205209
}
206210

207-
// Preserve arrival order while the initial authoritative membership
208-
// lookup is pending. A failed lookup clears this buffer fail-closed.
211+
// Preserve arrival order until initial membership and TTS state are
212+
// both known. A failed readiness check clears this buffer fail-closed.
209213
const routeId = allocateTtsRouteId();
210214
if (!agentsLoaded) {
211215
console.debug(
212216
`[huddle] tts stage=eligibility status=deferred reason=membership_unavailable route_id=${routeId}`,
213217
);
214218
}
215-
initialMembershipGate.push({ event, routeId });
219+
initialReadinessGate.push({ event, routeId });
216220
})
217221
.then((dispose) => {
218222
if (disposed) {

0 commit comments

Comments
 (0)