Repository navigation
Commit 9411463
authored
fix: keep field metadata in the result of min and max (apache#26939)
## Which issue does this PR close?
- Closes apache#26916.
## Rationale for this change
`max` and `min` return a value of the type of their argument, but they
drop the field metadata of the argument, including Arrow extension
types: `max(uuid_col)` is a plain `FixedSizeBinary(16)`. `first_value`
already keeps the metadata.
## What changes are included in this PR?
- `Max` and `Min` implement `return_field`. It builds the same field as
before and adds the metadata of the argument field, as `first_value`
does.
- `AggregateStatistics` replaces aggregates that the statistics answer,
such as `min` and `max` over a Parquet file, with literals. These
literals had no metadata, so the result lost it even with the change
above. They now get the metadata of the aggregate field. This is the
same kind of problem as apache#26855.
## What is the testing strategy for this PR?
New cases in `metadata.slt`:
- `max` and `min` without grouping;
- with `GROUP BY`, which uses the groups accumulator;
- as window functions;
- over a Parquet file, where the statistics answer the query. The case
checks with `EXPLAIN` that the plan is a projection of literals.
A new case in `cast_extension_type_metadata.slt` for `max` and `min` of
a `UUID` column, as in the issue. Its input contains a `NULL`, because
over a non-null column the query fails with an internal error on
nullability. That is a separate bug, apache#26469.
All new cases fail without the change.
## Are there any user-facing changes?
The result of `min` and `max` keeps the field metadata of the argument,
including extension types. There are no API changes.1 parent e77a370 commit 9411463
4 files changed
Lines changed: 117 additions & 4 deletions
File tree
- datafusion
- functions-aggregate/src
- physical-optimizer/src
- sqllogictest/test_files
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
27 | | - | |
| 28 | + | |
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
| |||
207 | 208 | | |
208 | 209 | | |
209 | 210 | | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
210 | 221 | | |
211 | 222 | | |
212 | 223 | | |
| |||
220 | 231 | | |
221 | 232 | | |
222 | 233 | | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
223 | 238 | | |
224 | 239 | | |
225 | 240 | | |
| |||
448 | 463 | | |
449 | 464 | | |
450 | 465 | | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
451 | 470 | | |
452 | 471 | | |
453 | 472 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
| 11 | + | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
| 15 | + | |
13 | 16 | | |
14 | 17 | | |
15 | 18 | | |
16 | 19 | | |
17 | 20 | | |
18 | 21 | | |
19 | | - | |
20 | 22 | | |
21 | 23 | | |
22 | 24 | | |
| |||
67 | 69 | | |
68 | 70 | | |
69 | 71 | | |
| 72 | + | |
70 | 73 | | |
71 | | - | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
72 | 78 | | |
73 | 79 | | |
74 | 80 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
88 | 108 | | |
89 | 109 | | |
90 | 110 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
346 | 346 | | |
347 | 347 | | |
348 | 348 | | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
349 | 373 | | |
350 | 374 | | |
351 | 375 | | |
| |||
498 | 522 | | |
499 | 523 | | |
500 | 524 | | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
501 | 534 | | |
502 | 535 | | |
503 | 536 | | |
| |||
548 | 581 | | |
549 | 582 | | |
550 | 583 | | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
551 | 619 | | |
552 | 620 | | |
553 | 621 | | |
| |||
0 commit comments