Fix div not allowed in summary element in ToC#552
Merged
adityatelange merged 1 commit intoadityatelange:masterfrom Sep 3, 2021
danielfdickinson:pr-toc-div-not-allowed
Merged
Fix div not allowed in summary element in ToC#552adityatelange merged 1 commit intoadityatelange:masterfrom danielfdickinson:pr-toc-div-not-allowed
adityatelange merged 1 commit intoadityatelange:masterfrom
danielfdickinson:pr-toc-div-not-allowed
Conversation
Signed-off-by: Daniel F. Dickinson <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
kylethedeveloper
pushed a commit
to kylethedeveloper/hugo-PaperMod
that referenced
this pull request
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








What does this PR change? What problem does it solve?
As per Mozilla Developer Network detail summary element page only 'phrasing elements' and/or one element of heading content are allowed inside a <summary> element.
Once again found by (valid) html validator complaint (I turn off the parts that are about opinions vs. HTML standards).
The table of contents <summary> currently contains a <div>.
I have replaced the <div> with a <span> and it appears to work on https://www.princesandmadmen.ca/post/schizophrenia-talk/ although increasing the font-size might be desirable.
Was the change discussed in an issue or in the Discussions before?
Closes #550
PR Checklist