Skip to content

Add social icon for snapchat#188

Merged
adityatelange merged 3 commits intoadityatelange:masterfrom
daksh7011:feature/snapchat-icon
Jan 23, 2021
Merged

Add social icon for snapchat#188
adityatelange merged 3 commits intoadityatelange:masterfrom
daksh7011:feature/snapchat-icon

Conversation

@daksh7011
Copy link
Copy Markdown
Contributor

@daksh7011 daksh7011 commented Jan 23, 2021

Add social icon for Snapchat.

The SVG is taken from Snapchat official assets, So please try not to modify it.

@daksh7011
Copy link
Copy Markdown
Contributor Author

daksh7011 commented Jan 23, 2021

This PR will close #186 when merged.

@daksh7011
Copy link
Copy Markdown
Contributor Author

daksh7011 commented Jan 23, 2021

@adityatelange Please review and merge the PR at your convenience.

adityatelange
adityatelange requested changes Jan 23, 2021
View reviewed changes
Copy link
Copy Markdown
Owner

@adityatelange adityatelange left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't match style of SVGs already present.
Won't look good with dark and light mode.

@adityatelange adityatelange linked an issue Jan 23, 2021 that may be closed by this pull request
Add new icon for Snapchat #186
Closed
@daksh7011
Copy link
Copy Markdown
Contributor Author

daksh7011 commented Jan 23, 2021 •
edited
Loading

Light Mode preview
image

Dark Mode preview:
image

It does look good, Changing the SVG would break Snapchat's ToS which states: "Don’t alter, rotate, or modify the Ghost logo in any way, such as by changing colors or adding"

Edit: There is a potential change regarding the view port size for SVG. I will have a look into that.

@adityatelange
Copy link
Copy Markdown
Owner

adityatelange commented Jan 23, 2021

@daksh7011 Why not use icon from simpleicons.org and modify accordingly ? Better licensing, smaller size.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@daksh7011
Copy link
Copy Markdown
Contributor Author

daksh7011 commented Jan 23, 2021

@adityatelange I have changed the svg from official one to SimpleIcons.org.

Have a look at your convenience.

adityatelange
adityatelange approved these changes Jan 23, 2021
View reviewed changes
Copy link
Copy Markdown
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Although it is not of wire type, it's fine IMO.
Merging, Thanks !

@adityatelange adityatelange merged commit 24afe95 into adityatelange:master Jan 23, 2021
@adityatelange
Copy link
Copy Markdown
Owner

adityatelange commented Jan 23, 2021

@daksh7011 It would be great if you could also add the icon to icon list :)
https://github.com/adityatelange/hugo-PaperMod/blob/exampleSite/content/posts/papermod/papermod-icons.md

@daksh7011
Copy link
Copy Markdown
Contributor Author

daksh7011 commented Jan 23, 2021

@adityatelange I can add a alternate logo with just strokes as snapchat-alt. Let me know, I will add it.

@adityatelange adityatelange added the icons Related to Icons label Jun 11, 2021
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
@daksh7011
Add social icon for snapchat (adityatelange#188)
8697f70 
Credits for icon: https://simpleicons.org/?q=snapchat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityatelange adityatelange adityatelange approved these changes

Assignees

No one assigned

Labels

icons Related to Icons

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add new icon for Snapchat

2 participants

@daksh7011 @adityatelange