Closed
Conversation
adisbladis
requested changes
Mar 27, 2020
Author
|
Updated with the feedback I could address so far :) |
name is of type Optional[str] and can therefore be None. In the `nixops info` output we default to the deployment UUID so it feels reasonable to fall back sorting on UUID.
It's been replaced by pyproject.toml
We need to evaluate twice, once using any previous version of mypy and a second time using the current version of mypy. If we don't a mypy version bump can find new type errors that makes the initial check fail.
Based on: Grepping the source code for RawValue, I see they are all strings.
Based on grepping the source code for MultiLineRawValue, it apears they're all just a list of RawValue values, ie: str's
adisbladis
force-pushed
the
poetry2nix-plugins
branch
from
845e5ab to
8f6ba79
Compare
grahamc
force-pushed
the
poetry-plugin-docs
branch
from
9105745 to
171530c
Compare
Co-Authored-By: adisbladis <[email protected]>
grahamc
force-pushed
the
poetry-plugin-docs
branch
from
171530c to
64ee0eb
Compare
Author
|
Updated to use the 20.03 updates to poetry2nix! |
adisbladis
reviewed
Mar 28, 2020
| buildInputs = [ | ||
| (pkgs.poetry2nix.mkPoetryEnv { | ||
| projectDir = ./.; | ||
| overrides = pkgs.poetry2nix.overrides.withoutDefaults overrides; |
Author
There was a problem hiding this comment.
I'm not sure, I copy-pasted it from the wrong section of the poetry2nix docs by misake :) Can you fix it?
adisbladis
force-pushed
the
poetry2nix-plugins
branch
from
8f6ba79 to
8fce650
Compare
Owner
|
Squashed and merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.