Repository navigation
Conversation
Contributor
|
Hi @TemRevil , thanks for your contribution! We will try to give it some priority during the following weeks. |
Author
|
awe, you're alive? |
Contributor
|
Included as part of release 2.2.1. |
Author
|
Thanks for getting it into 2.2.1, and no worries about the wait. If there is anything else in the backlog you would like a hand with, I am glad to pick it up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebase of #9 onto current master, nothing else. That PR was approved back in January 2024 but never merged, and it's now 24 commits behind, which is probably why it's stuck.
I cherry-picked Gabriel's original commit as-is (same author, same files), and checked that
add_current_date,rename,with_expressions,custom_transformation, andoptimize_datasetstill work the same way on current master. No conflicts, no changes to the actual sample.Feel free to close this in favor of Gabriel just updating his own branch if that's simpler on your end. Either way the credit should go to him, this is his work, I just moved it forward a couple years.