Fix allOf + additionalProperties validation and add oneOf titles#334
Merged
Fix allOf + additionalProperties validation and add oneOf titles#334
Conversation
Fixes JSON Schema validation failures when using allOf composition with
additionalProperties: false. Each sub-schema was independently rejecting
the other's properties.
**Schema fixes:**
- dimensions.json: removed additionalProperties: false (composition-only)
- push-notification-config.json: removed additionalProperties: false
- video-asset.json: inlined width/height, removed allOf
- image-asset.json: inlined width/height, removed allOf
**Bundled schemas:**
- Added bundled schemas at /schemas/{version}/bundled/
- Only bundles request/response schemas (root schemas)
- Core objects are embedded inside response schemas when bundled
- Custom resolveRefs() handles multiple refs to same schema correctly
- Generated at build time for tools that don't support $ref resolution
**Testing:**
- New test:composed script validates allOf composition patterns
- Tests bundled schemas work without $ref resolution
- Added to CI test suite
Fixes #275.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Adds explicit title properties to all oneOf variants in response schemas so downstream UI tools display meaningful labels instead of "Option 1", "Option 2" when rendering discriminated unions. Schemas updated: - create-media-buy-response: CreateMediaBuySuccess/Error - update-media-buy-response: UpdateMediaBuySuccess/Error - sync-creatives-response: SyncCreativesSuccess/Error - build-creative-response: BuildCreativeSuccess/Error - provide-performance-feedback-response: ProvidePerformanceFeedbackSuccess/Error - activate-signal-response: ActivateSignalSuccess/Error - preview-creative-response: PreviewCreativeSingleResponse/BatchResponse + nested batch result titles 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
The dimensions schema was no longer referenced after inlining width/height properties directly into video-asset.json and image-asset.json. This removes the unused schema file and updates tests accordingly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Adds a warning that bundled schemas are experimental and may change, with a link to share feedback on use cases. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allOf+additionalProperties: falseconflict causing AJV validation failures (fixes allOf + additionalProperties: false in asset schemas causes validation failures for official examples #275)oneOfvariants in response schemas for better UI tooling$refresolutiondimensions.jsonschemaChanges
Schema fixes:
video-asset.jsonandimage-asset.jsoninstead of usingallOfwithdimensions.jsononeOfvariants in response schemas (e.g.,CreateMediaBuySuccess,CreateMediaBuyError) so UI tools show meaningful labels instead of "Option 1", "Option 2"dimensions.jsonschemaNew features (experimental):
build-schemas.js- creates self-contained schemas with all$refresolved inlineschema-versioning.mdxwith experimental warningTesting:
composed-schema-validation.test.jsto catchallOf+additionalPropertiesconflictsTest plan
loadSchemaconfiguration🤖 Generated with Claude Code