Repository navigation
fix: recognize feed links whose rel is not exactly "alternate" - #1013
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1013 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 21 21
Lines 4358 4358
=======================================
Hits 4356 4356
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
determine_feed()selects feed links with//link[@rel="alternate"], an exact string match. In HTML,relis a case-insensitive list of space-separated keywords, so feeds declared as<link rel="Alternate" ...>,rel="ALTERNATE",rel="alternate feed"or with surrounding spaces were not found at all, and the<a href>backup does not look at<link>elements. Thetypeattribute is already normalized for case and; charset=suffixes;relwas not.Links are now kept when
alternateis one of theirrelkeywords, compared case-insensitively. Other links, such as stylesheets orrel="alternative", are still ignored. Added a test next totest_determine_feed_type_normalization.