feat(csv-parse): null comment_no_infix type

wdavidw · wdavidw · commit d8bf4fd1fb81 · 2025-06-06T18:09:47.000+02:00
diff --git a/packages/csv-parse/lib/index.d.ts b/packages/csv-parse/lib/index.d.ts
@@ -114,7 +114,7 @@ export interface Options<T = string[]> {
    * defined in the middle of the line are not interpreted as such. The
    * option require the activation of comments.
    */
-  comment_no_infix?: boolean;
+  comment_no_infix?: boolean | null;
   /**
    * Set the field delimiter. One character only, defaults to comma.
    */
diff --git a/packages/csv-parse/test/option.comment_no_infix.js b/packages/csv-parse/test/option.comment_no_infix.js
@@ -3,10 +3,6 @@ import { parse } from "../lib/index.js";
 
 describe("Option `comment_no_infix`", function () {
   it("validation", function () {
-    parse("", { comment_no_infix: undefined }, () => {});
-    parse("", { comment_no_infix: null }, () => {});
-    parse("", { comment_no_infix: false }, () => {});
-    parse("", { comment_no_infix: true }, () => {});
     (() => {
       parse("", { comment_no_infix: "" }, () => {});
     }).should.throw({
@@ -22,52 +18,4 @@ describe("Option `comment_no_infix`", function () {
       code: "CSV_INVALID_OPTION_COMMENT",
     });
   });
-
-  it("with `true`, field starting with comment", function (next) {
-    parse(
-      "a,#,c",
-      {
-        comment: "#",
-        comment_no_infix: true,
-      },
-      (err, records) => {
-        if (!err) {
-          records.should.eql([["a", "#", "c"]]);
-        }
-        next(err);
-      },
-    );
-  });
-
-  it("with `true`, field not starting with comment", function (next) {
-    parse(
-      "a,b#,c",
-      {
-        comment: "#",
-        comment_no_infix: true,
-      },
-      (err, records) => {
-        if (!err) {
-          records.should.eql([["a", "b#", "c"]]);
-        }
-        next(err);
-      },
-    );
-  });
-
-  it("with `false`", function (next) {
-    parse(
-      "a,b#,c",
-      {
-        comment: "#",
-        comment_no_infix: false,
-      },
-      (err, records) => {
-        if (!err) {
-          records.should.eql([["a", "b"]]);
-        }
-        next(err);
-      },
-    );
-  });
 });
diff --git a/packages/csv-parse/test/option.comment_no_infix.ts b/packages/csv-parse/test/option.comment_no_infix.ts
@@ -0,0 +1,59 @@
+import "should";
+import { parse } from "../lib/index.js";
+
+describe("Option `comment_no_infix`", function () {
+  it("validation", function () {
+    parse("", { comment_no_infix: undefined }, () => {});
+    parse("", { comment_no_infix: null }, () => {});
+    parse("", { comment_no_infix: false }, () => {});
+    parse("", { comment_no_infix: true }, () => {});
+  });
+
+  it("with `true`, field starting with comment", function (next) {
+    parse(
+      "a,#,c",
+      {
+        comment: "#",
+        comment_no_infix: true,
+      },
+      (err, records) => {
+        if (!err) {
+          records.should.eql([["a", "#", "c"]]);
+        }
+        next(err);
+      },
+    );
+  });
+
+  it("with `true`, field not starting with comment", function (next) {
+    parse(
+      "a,b#,c",
+      {
+        comment: "#",
+        comment_no_infix: true,
+      },
+      (err, records) => {
+        if (!err) {
+          records.should.eql([["a", "b#", "c"]]);
+        }
+        next(err);
+      },
+    );
+  });
+
+  it("with `false`", function (next) {
+    parse(
+      "a,b#,c",
+      {
+        comment: "#",
+        comment_no_infix: false,
+      },
+      (err, records) => {
+        if (!err) {
+          records.should.eql([["a", "b"]]);
+        }
+        next(err);
+      },
+    );
+  });
+});
