feat(csv-parse): on_skip catch thrown error

wdavidw · wdavidw · commit 987a3a9a6873 · 2025-05-13T10:30:19.000+02:00
diff --git a/packages/csv-parse/lib/api/index.js b/packages/csv-parse/lib/api/index.js
@@ -861,10 +861,14 @@ const transform = function (original_options = {}) {
       if (skip_records_with_error) {
         this.state.recordHasError = true;
         if (this.options.on_skip !== undefined) {
-          this.options.on_skip(
-            err,
-            raw ? this.state.rawBuffer.toString(encoding) : undefined,
-          );
+          try {
+            this.options.on_skip(
+              err,
+              raw ? this.state.rawBuffer.toString(encoding) : undefined,
+            );
+          } catch (err) {
+            return err;
+          }
         }
         // this.emit('skip', err, raw ? this.state.rawBuffer.toString(encoding) : undefined);
         return undefined;
diff --git a/packages/csv-parse/test/option.on_skip.js b/packages/csv-parse/test/option.on_skip.js
@@ -1,4 +1,5 @@
 import "should";
+import dedent from "dedent";
 import { parse } from "../lib/index.js";
 import { assert_error } from "./api.assert_error.js";
 
@@ -10,6 +11,27 @@ describe("Option `on_skip`", function () {
     }).should.throw("Invalid Option: on_skip must be a function, got 1");
   });
 
+  it("catch thrown error", function (next) {
+    parse(
+      dedent`
+          a,b,c,d
+          invalid
+          e,f,g,h
+        `,
+      {
+        bom: true,
+        skip_records_with_error: true,
+        on_skip: () => {
+          throw Error("Catchme");
+        },
+      },
+      (err) => {
+        err.message.should.eql("Catchme");
+        next();
+      },
+    );
+  });
+
   it('handle "CSV_RECORD_INCONSISTENT_FIELDS_LENGTH" with bom (fix #411)', function (next) {
     let errors = 0;
     const parser = parse(
@@ -36,10 +58,13 @@ describe("Option `on_skip`", function () {
         next(err);
       },
     );
-    parser.write(`a,b,c,d
-1,2,3
-e,f,g,h
-`);
+    parser.write(
+      dedent`
+        a,b,c,d
+        1,2,3
+        e,f,g,h
+      `,
+    );
     parser.end();
   });
 });
