Skip to content

Commit 24af461

Browse files
committed
feat(csv-parse): input as Uint8Array (fix #458)
1 parent 388daf8 commit 24af461

3 files changed

Lines changed: 14 additions & 7 deletions

File tree

packages/csv-parse/lib/index.d.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -473,12 +473,12 @@ type OptionsWithColumns<T> = Omit<Options<T>, "columns"> & {
473473
};
474474

475475
declare function parse<T = unknown>(
476-
input: string | Buffer,
476+
input: string | Buffer | Uint8Array,
477477
options: OptionsWithColumns<T>,
478478
callback?: Callback<T>,
479479
): Parser;
480480
declare function parse(
481-
input: string | Buffer,
481+
input: string | Buffer | Uint8Array,
482482
options: Options,
483483
callback?: Callback,
484484
): Parser;
@@ -489,7 +489,10 @@ declare function parse<T = unknown>(
489489
): Parser;
490490
declare function parse(options: Options, callback?: Callback): Parser;
491491

492-
declare function parse(input: string | Buffer, callback?: Callback): Parser;
492+
declare function parse(
493+
input: string | Buffer | Uint8Array,
494+
callback?: Callback,
495+
): Parser;
493496
declare function parse(callback?: Callback): Parser;
494497

495498
// export default parse;

packages/csv-parse/lib/sync.d.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,14 @@ type OptionsWithColumns<T> = Omit<Options<T>, "columns"> & {
55
};
66

77
declare function parse<T = unknown>(
8-
input: Buffer | string,
8+
input: Buffer | string | Uint8Array,
99
options: OptionsWithColumns<T>,
1010
): T[];
11-
declare function parse(input: Buffer | string, options: Options): string[][];
12-
declare function parse(input: Buffer | string): string[][];
11+
declare function parse(
12+
input: Buffer | string | Uint8Array,
13+
options: Options,
14+
): string[][];
15+
declare function parse(input: Buffer | string | Uint8Array): string[][];
1316

1417
// export default parse;
1518
export { parse };
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,8 @@ describe("API sync", function () {
5757
parse("A,B\nB\nC,K", { trim: true });
5858
throw Error("Error not catched");
5959
} catch (err) {
60-
err.message.should.eql(
60+
if (!err) throw Error("Invalid assessment");
61+
(err as Error).message.should.eql(
6162
"Invalid Record Length: expect 2, got 1 on line 2",
6263
);
6364
}

0 commit comments

Comments
 (0)