Skip to content

Fix inconsistencies #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhalbert merged 2 commits into from
Jun 23, 2024
Merged

Fix inconsistencies #165

dhalbert merged 2 commits into from
Jun 23, 2024

Conversation

@justmobilize
Copy link
Collaborator

@justmobilize justmobilize commented Jun 6, 2024

  • Add ipv4_address to match native wifi and esp32spi
  • Fix recvfrom_into to return the correct address info

@justmobilize
Fix inconsistencies:
abfd62b 
- Add ipv4_address to match native wifi and esp32spi
- Fix recvfrom_into to return the correct address info
@justmobilize justmobilize force-pushed the fix-inconsistencies branch from 2885a4d to abfd62b Compare June 6, 2024 22:10
@justmobilize justmobilize requested a review from dhalbert June 6, 2024 22:12
@justmobilize
Copy link
Collaborator Author

justmobilize commented Jun 6, 2024

@anecdata would appreciate your eyes as well

@justmobilize justmobilize marked this pull request as ready for review June 6, 2024 22:12
anecdata
anecdata reviewed Jun 6, 2024
View reviewed changes
Copy link
Member

@anecdata anecdata left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on PicoW + WIZnet 5100S Pico hat. Client sends, server receives then sends, client receives... rinse, repeat.

Consistent with native wifi, and (more recently) esp32spi:
print(f'{radio.ipv4_address}')
now outputs IP address string:
192.168.5.208

anecdata
anecdata reviewed Jun 6, 2024
View reviewed changes
@justmobilize
Copy link
Collaborator Author

justmobilize commented Jun 10, 2024

@dhalbert any concerns with this?

dhalbert
dhalbert approved these changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert dhalbert merged commit c63bf6b into adafruit:main Jun 23, 2024
@justmobilize justmobilize deleted the fix-inconsistencies branch June 23, 2024 20:34
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 2, 2024
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@d723e94)
571a947 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 2.2.26 from 2.2.25:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#97 from caternuson/doc_update

Updating https://github.com/adafruit/Adafruit_CircuitPython_HX711 to 1.0.1 from 1.0.0:
  > update pins for Feather

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 7.1.3 from 7.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#165 from justmobilize/fix-inconsistencies

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.8.3 from 5.8.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#120 from adafruit/tyeth/issue119

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anecdata anecdata anecdata left review comments

@dhalbert dhalbert dhalbert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justmobilize @dhalbert @anecdata