Preserve the real error if accept failed. #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the exception would be about the variable 'conn' never being assigned a value. This scenario came up when there was an internal bug in circuitpython sockets that made accept fail; however, it might be the case that accept can "normally" fail, e.g., if all sockets are exhausted.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 17, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.5.5 from 4.5.4: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#82 from jepler/fix-failed-accept Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the exception would be about the variable 'conn' never being assigned a value.
This scenario came up when there was an internal bug in circuitpython sockets that made accept fail; however, it might be the case that accept can "normally" fail, e.g., if all sockets are exhausted.