Add list of dicts support to send_batch_data #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev. |
tyeth
force-pushed
the
update_batch_send_to_take_dict
branch
from
12755ed to
26c459f
Compare
Member
Author
|
@brentru this is ready for review |
brentru
approved these changes
Jul 18, 2024
Member
brentru
left a comment
brentru
left a comment
There was a problem hiding this comment.
I like this implementation but really like the included example. LGTM!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 20, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.9.0 from 5.8.3: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#125 from adafruit/update_batch_send_to_take_dict > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#124 from adafruit/tyeth/issue97 > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#123 from adafruit/tyeth/issue122 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for passing a list of dicts to send_batch_data, previously it only accepted namedtuple-like things (requiring_asdict() method). To avoid breaking people who use this uncommon method, the implementation switches on whether a list of dicts was passed, or not (namedtuples).
An example has been added to allow people to quickly test it via cpython. It generates 5 datapoints at 1second intervals in the past then batch sends and shows a url to view the feed graph/data.