Highlight usage of different methods for group feeds + cleanup multigroup feeds #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roup feeds User feedback was: "add_feed_to_group() is not working - used adafruit_io_groups.py example as a test case." Fixes #119
brentru
approved these changes
Jun 25, 2024
|
That's fixes one of the issues. But I still get an error when I try add an existing feed to the sensors group using The API has the error or the error is in code of the library file |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 2, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 2.2.26 from 2.2.25: > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#97 from caternuson/doc_update Updating https://github.com/adafruit/Adafruit_CircuitPython_HX711 to 1.0.1 from 1.0.0: > update pins for Feather Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 7.1.3 from 7.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#165 from justmobilize/fix-inconsistencies Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.8.3 from 5.8.2: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#120 from adafruit/tyeth/issue119 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User feedback (support issue) was:
It appears the code has changed since the example was written and there is a newer "create_feed_in_group" method.
It's also the case that the
add_feed_to_groupmethod always required an existing feed (at least according to the comments in code).I've expanded the example to:
Whereas the humidity one was created in the Default group and simply gained association to a second group.
Fixes #119