Skip to content

Comments

fix(test): remove nonexistent url_pattern::to_string() call#971

Merged
lemire merged 1 commit intoada-url:mainfrom
watilde:fix/test
Jul 7, 2025
Merged

fix(test): remove nonexistent url_pattern::to_string() call#971
lemire merged 1 commit intoada-url:mainfrom
watilde:fix/test

Conversation

@watilde
Copy link
Contributor

@watilde watilde commented Jul 6, 2025

This PR fixes a test error with ada_log caused by calling a nonexistent to_string method on url_pattern. According to the WHATWG specification, url_pattern does not provide a to_string method. Instead of implementing a to_string method, I changed the logging output.

Steps to reproduce:

cmake -B build -DADA_TESTING=ON
cmake --build build 
ADA_LOGGING=1 ctest --output-on-failure --test-dir build

Outputs:

parse_result:
  protocol: 'https'
  username: 'user'
  password: 'pass'
  hostname: 'example.com'
  port: '8080'
  pathname: '/path'
  search: '?query'
  hash: '#fragment'

Refs:

@lemire lemire merged commit 8fd0024 into ada-url:main Jul 7, 2025
47 checks passed
@watilde watilde deleted the fix/test branch July 7, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants