fix(test): remove nonexistent url_pattern::to_string() call#971
Merged
lemire merged 1 commit intoada-url:mainfrom Jul 7, 2025
Merged
fix(test): remove nonexistent url_pattern::to_string() call#971lemire merged 1 commit intoada-url:mainfrom
lemire merged 1 commit intoada-url:mainfrom
Conversation
lemire
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a test error with
ada_logcaused by calling a nonexistentto_stringmethod on url_pattern. According to the WHATWG specification,url_patterndoes not provide ato_stringmethod. Instead of implementing ato_stringmethod, I changed the logging output.Steps to reproduce:
Outputs:
Refs: