Skip to content

Compatible with repository addresses using http protocol. - #175

Merged
ZPascal merged 1 commit into
ad-m:masterfrom
kerwin612:patch-1
Jul 27, 2023
Merged

ZPascal merged 1 commit into
ad-m:masterfrom
kerwin612:patch-1

Conversation

@kerwin612

Copy link
Copy Markdown
Contributor

Compatible with repository addresses using http protocol.

I am using this action on my company's internal Gitea platform.
Exposed this issue, this PR was tested locally to fix this issue.
Gitea is a Github-like product that can be deployed on a company's local area network(Our internal Gitea instance uses the http protocol.). He implemented a set of fully compatible Github Actions with reference to Github Actions, so we can also use github-push-action;

Compatible with repository addresses using http protocol.
@kerwin612 kerwin612 changed the title Update start.js Compatible with repository addresses using http protocol. Jul 26, 2023
@ZPascal

ZPascal commented Jul 26, 2023 •

Copy link
Copy Markdown
Collaborator

Hi @kerwin612, thank you for the contribution. Do you have already tested it on the Gitea act runners? I've got not a Gitea (without TLS)/ GTE system at the hand the validate this scenario.

@ZPascal ZPascal self-assigned this Jul 26, 2023
@kerwin612

kerwin612 commented Jul 26, 2023 •

Copy link
Copy Markdown
Contributor Author

Hi @kerwin612, thank you for the contribution. Do you have already tested it on the Gitea act runners? I've got not a Gitea (without TLS)/ GTE system at the hand the validate this scenario.

20230726183138
Yes, this is a must, this PR patch has been running inside us; Perfect compatibility; thank you for open-source this repository.

@ZPascal

ZPascal commented Jul 26, 2023

Copy link
Copy Markdown
Collaborator

@kerwin612 Glad to hear that. I'll run a classic Github action test on my end. If everything works as expected, I will merge the PR.

@ZPascal ZPascal left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The test was performed successfully.

@ZPascal
ZPascal merged commit f8e0bce into ad-m:master Jul 27, 2023
@stefan-gorules

stefan-gorules commented Jul 27, 2023 •

Copy link
Copy Markdown

Hi this likely just broke pipeline on our end https://github.com/gorules/zen/actions/runs/5684712114/job/15408012121 under "Push changes"

@ZPascal

ZPascal commented Jul 27, 2023

Copy link
Copy Markdown
Collaborator

Hi @stefan-gorules, thank you for the notification. I'll revert the change and set up a test case based on your setup.

ZPascal added a commit that referenced this pull request Jul 27, 2023
ZPascal added a commit that referenced this pull request Jul 27, 2023
@kerwin612
kerwin612 deleted the patch-1 branch July 27, 2023 20:23
@kerwin612
kerwin612 restored the patch-1 branch July 27, 2023 20:28
@kerwin612

Copy link
Copy Markdown
Contributor Author

Hi this likely just broke pipeline on our end https://github.com/gorules/zen/actions/runs/5684712114/job/15408012121 under "Push changes"

see #178 Using https by default can fix your problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants