Repository navigation
fix: github_token and github_url optional - #134
Merged
Merged
Conversation
SevereCloud
commented
Jun 28, 2022
SevereCloud
commented
Contributor
Collaborator
|
Hi Daniil, could you please describe detailed the case. A screenshot from VSCode is not the best description, and in general the parameters are marked as required and using default values. |
Contributor
Author
A parameter cannot be required and have a default value at the same time |
Collaborator
Hi @SevereCloud, that's valid. |
ZPascal
self-requested a review
June 28, 2022 12:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.