Repository navigation
Consider renaming input from 'github_token' to 'github-token'? #56
Description
Hi! Today I was trying to play around with some updates using github-push-action and I noticed I was getting the error:
##[warning]Unexpected input 'github-token', valid inputs are ['github_token', 'repository', 'branch', 'force', 'tags', 'directory']
I was quite confused by this until I read closer and noticed that I had used github-token in
- name: Push changes
uses: ad-m/[email protected]
with:
github-token: ${{ secrets.GITHUB_TOKEN }}instead of github_token
- name: Push changes
uses: ad-m/[email protected]
with:
github_token: ${{ secrets.GITHUB_TOKEN }}As the GitHub github-script action uses github-token, would you consider changing the input to match them? My library is probably not the only one that uses both github-script and github-push-action so it would probably lead to less typos and errors. If there was a reason that you intentionally chose to not copy them then my apologies for missing this.
I also just wanted to say thank you, as your GitHub Action is awesome and we use it quite heavily in our publication workflow for our library pyhf.
Activity
ad-m commentedon May 30, 2020
I do not feel comfortable to drop "github_token" support, but I will gladly accept PR, which will simultaneously introduce support for "github-token" with an indication of the recommended solution consistent with proposd.
ZPascal commentedon May 23, 2026
This has been implemented in #375. The
tokeninput is now supported as the primary input name, matching the convention used byactions/checkout. The existinggithub_tokeninput remains fully functional as a fallback, so no existing workflows will break.Note: The input was intentionally not named
github-token(with a hyphen), as that would break the existing naming convention of this action — all current inputs use underscores (e.g., force_with_lease, push_only_tags). Using a hyphen would introduce an inconsistency across the input API.