Merged
Conversation
scarroll32
changed the title
scarroll32
requested review from
Copilot
and removed request for
scarroll32
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new search_form_with helper method to the FormHelper module that provides the same functionality as search_form_for but uses the modern form_with instead of the legacy form_for. This addresses issue #962 by providing a contemporary alternative while maintaining backward compatibility.
- Added
search_form_withmethod that mirrorssearch_form_forfunctionality - Added comprehensive test coverage for all scenarios including format handling, array routing, and custom search keys
- Maintained backward compatibility by keeping existing helpers intact
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/ransack/helpers/form_helper.rb | Implements the new search_form_with method and supporting finalize_form_with_options helper |
| spec/ransack/helpers/form_helper_spec.rb | Adds comprehensive test suite covering all search_form_with scenarios and edge cases |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
scarroll32
deleted the
copilot/fix-f8b46e71-f425-4f4a-8480-1efbad2ed495
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional instructions:
Fixes #962
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.