Fix ActiveRecord::normalizes breaking LIKE predicates wildcards#1587
Merged
scarroll32 merged 5 commits intomainfrom Sep 24, 2025
Merged
Fix ActiveRecord::normalizes breaking LIKE predicates wildcards#1587scarroll32 merged 5 commits intomainfrom
scarroll32 merged 5 commits intomainfrom
Conversation
Co-authored-by: scarroll32 <[email protected]>
Co-authored-by: scarroll32 <[email protected]>
Copilot
AI
changed the title
[WIP] [BUG][RoR 7.1] ActiveRecord::normalizes can break
Fix ActiveRecord::normalizes breaking LIKE predicates wildcards
Sep 24, 2025
cont predicate
scarroll32
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
ActiveRecord::normalizes(introduced in Rails 7.1) was interfering with LIKE wildcard patterns in Ransack searches, causing incorrect SQL generation.Problem
When using
ActiveRecord::normalizeson a model attribute, Ransack's LIKE-based predicates (cont,i_cont,start,end, etc.) were having their wildcard patterns normalized, breaking the search functionality:The issue occurred because ActiveRecord's normalization was being applied to values that Ransack had already formatted with LIKE wildcards (
%foo%→_foo_).Solution
The fix uses
Arel::Nodes.build_quotedto wrap formatted values for LIKE predicates, which bypasses ActiveRecord's normalization while preserving it for other predicate types:cont,start,end, etc.): Wildcards are preserved, normalization bypassedeq,gt, etc.): Normalization still applies to search values as expectedChanges
lib/ransack/nodes/condition.rbto detect LIKE predicates and wrap their values appropriatelyActiveRecord::normalizesTesting
The fix includes tests that verify:
Resolves the issue described in the original bug report where
%characters in LIKE patterns were being converted to_by normalization.Additional instructions:
Fixes #1488
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.