Merged
Conversation
scarroll32
requested review from
Copilot
and removed request for
scarroll32
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for Rails 7.1 from the Ransack gem in preparation for Rails 7.1's end-of-life on October 1, 2025. The changes update dependency requirements and remove Rails 7.1 from testing environments.
- Updated minimum Rails dependency from 7.1 to 7.2 in gemspec
- Simplified conditional logic for ActiveSupport deprecator since Rails 7.2+ always includes it
- Removed Rails 7.1 from CI test matrix across all database environments
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ransack.gemspec | Updated Rails dependencies to require version 7.2 or higher |
| lib/ransack.rb | Removed version check for active_support/deprecator since Rails 7.2+ always includes it |
| docs/docs/intro.md | Updated documentation to reflect Rails 8.0 and 7.2 support only |
| README.md | Updated Rails version support statement to remove 7.1 |
| CHANGELOG.md | Added entry documenting Rails 7.1 support removal |
| .github/workflows/test.yml | Removed Rails 7.1 from CI test matrix for all database environments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
scarroll32
force-pushed
the
copilot/fix-825743f9-dc09-41ed-94eb-03a77413adae
branch
from
acfc031 to
49f8838
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: scarroll32 <[email protected]>
Co-authored-by: scarroll32 <[email protected]>
Co-authored-by: Copilot <[email protected]>
scarroll32
force-pushed
the
copilot/fix-825743f9-dc09-41ed-94eb-03a77413adae
branch
from
43faa48 to
a5d2cd7
Compare
scarroll32
deleted the
copilot/fix-825743f9-dc09-41ed-94eb-03a77413adae
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails 7.1 reaches end-of-life on October 1, 2025, with security support ending on that date. This PR removes support for Rails 7.1 in preparation for that milestone.
Changes
>= 7.1to>= 7.2for bothactiverecordandactivesupportdependencieslib/ransack.rbby removing the version check foractive_support/deprecatorsince Rails 7.2+ always includes itv7.1.0from all test environments (SQLite3, MySQL, PostGIS, PostgreSQL) in the GitHub Actions workflowImportant Note
The changes are minimal and surgical, focusing only on version requirements while maintaining backward compatibility for all supported Rails versions (7.2+). Existing Rails 7+ specific test logic remains unchanged as it continues to apply to Rails 7.2+.
Fixes #1567