Prevent changing host through params#1391
Merged
deivid-rodriguez merged 1 commit intoactiverecord-hackery:mainfrom Jan 26, 2023
Merged
Prevent changing host through params#1391deivid-rodriguez merged 1 commit intoactiverecord-hackery:mainfrom
deivid-rodriguez merged 1 commit intoactiverecord-hackery:mainfrom
Conversation
AndersGM
force-pushed
the
prevent-changing-host-through-params
branch
2 times, most recently
from
4cc8317 to
8d653c1
Compare
deivid-rodriguez
force-pushed
the
prevent-changing-host-through-params
branch
from
24b1617 to
c140017
Compare
deivid-rodriguez
approved these changes
Jan 26, 2023
Contributor
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
There was a problem hiding this comment.
Thanks so much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it is possible to change the host simply by passing a host through params. This way, visiting
example.com/people?host=some_other_domainwould then have sort_links withhttp://some_other_domain/people...