Add support for default predicates#1384
Merged
scarroll32 merged 2 commits intoactiverecord-hackery:mainfrom Jan 29, 2023
Merged
Add support for default predicates#1384scarroll32 merged 2 commits intoactiverecord-hackery:mainfrom
scarroll32 merged 2 commits intoactiverecord-hackery:mainfrom
Conversation
Currently predicates are required, otherwise the conditions are ignored
or they will raise an error.
When using Ransack for filtering in json requests, it would be nice to
allow an empty predicate to equal to true.
So instead of having to explicitly pass '*_eq':
{
product_id_eq: 'product-1',
type_eq: 'admin
}
we can do the following:
{
product_id: 'product-1',
type: 'admin
}
This adds a `:default_predicate` configuration option that will be used
in case of a missing predicate.
Member
|
Thank you @p8 🚀 |
Contributor
Author
|
Thanks @scarroll32 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently predicates are required, otherwise the conditions are ignored or they will raise an error.
When using Ransack for filtering in json requests, it would be nice to allow an empty predicate to equal to true.
So instead of having to explicitly pass '*_eq':
we can do the following:
This adds a
:default_predicateconfiguration option that will be used in case of a missing predicate.I'm not sure anyone would use a different default, so maybe the config option should be something like:
:default_to_eq_predicate.