Skip to content

Conversation

@javierjulio
Copy link
Member

@javierjulio javierjulio commented Sep 22, 2025

The CSS dark mode styles remained incomplete. For example, the form controls were still using the initial values I took from Flowbite but they were too bright when compared to general dark mode implementations. Other elements I had already changed to a darker set of colors.

@javierjulio javierjulio self-assigned this Sep 22, 2025
@javierjulio javierjulio force-pushed the css-base-styles-update branch from d0cfdae to 02b698a Compare September 22, 2025 23:47
@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (f896454) to head (c6ffeb3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8809   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files         139      139           
  Lines        4043     4043           
=======================================
  Hits         4006     4006           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@javierjulio javierjulio changed the title Update CSS base styles for form controls Update dark mode CSS styles Sep 23, 2025
@javierjulio javierjulio force-pushed the css-base-styles-update branch 3 times, most recently from dc7af9f to 9e7724b Compare September 26, 2025 17:51
Now using darker colors for background-color, color and border-color styles.
Since these were taken from Flowbite to start, there are several issues. The ::file-selector-button was offset and wasn't rendered correctly. The offset was to add spacing between the button and generated browser text that we can't style. It would be preferred as a default to not offset. This applies same styles as other input controls to keep it simple and consistent. The :focus style was removed since it was invalid anyway and not applied by the browser.

This was partially addressed in #8574 but not targeting the right element. This approach is preferred to simplify the styles as the fix in #8574 (display block and overflow hidden) are unnecessary and cause undesired effects e.g. no border radius visible on left side of button.
This now uses a single text-gray-500 for both light and dark modes using the correct Tailwind syntax.
Originally, this required different background sizes due to the checkbox SVG but all 3 SVGs now account for being within a padded square box so we can now set a single background size of 100% for both elements. The checkbox SVGs had to be recreated for that. This also removes a duplicate rule (.dark [type='radio']:checked) because of CSS specificity which we no longer need.
For an attribute with multi line text (e.g. comment body), we want the column header to align to the top or specifically the baseline of the parent. This way the column text aligns nicely with the value text.
The attributes table heading dark mode color was too bright so this darkens it and is a nice contrast to mimic what its like in light mode. The empty value text is lighter now in dark mode too since it wasn't as visible.
This also updates the inline-errors to include the select element.
The SVG's use currentColor so it applies the (text) color of the parent element. We can further control this and for dark mode to make these nicer and standout.
@javierjulio javierjulio force-pushed the css-base-styles-update branch from 9e7724b to c6ffeb3 Compare October 3, 2025 23:18
@javierjulio javierjulio merged commit 7977365 into master Oct 3, 2025
27 checks passed
@javierjulio javierjulio deleted the css-base-styles-update branch October 3, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants