-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Upgrade Flowbite dependency to v3.1.2 #8692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Upgrades Flowbite from v2 to v3.1.2 to align with the current Tailwind CSS v3 environment, as confirmed by Flowbite's documentation. This proactive upgrade aims to minimize the diff and potential conflicts during the upcoming migration to Tailwind CSS v4. Ref: https://flowbite.com/docs/getting-started/quickstart/#tailwind-css-v3
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8692 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 141 141
Lines 4076 4076
=======================================
Hits 4040 4040
Misses 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| integrity sha512-MkwSgbbybCYgMC+go6Da5idEKUFfMqc/AmSjm/2ZbdmvoKf5frLPq/eIhXc9P+rC8t9boZtUXzHDgt5whZ6A/Q== | ||
| dependencies: | ||
| "@popperjs/core" "^2.9.3" | ||
| flowbite-datepicker "^1.3.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tagliala thanks for setting this up. Is that package version a blocker for getting this PR merged? Otherwise, the changes look good to me so I can approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say it is not a blocker, It does not appear to be used by default
javierjulio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Upgrades Flowbite from v2 to v3.1.2 to align with the current Tailwind CSS v3 environment, as confirmed by Flowbite's documentation.
This proactive upgrade aims to minimize the diff and potential conflicts during the upcoming migration to Tailwind CSS v4.
Ref: https://flowbite.com/docs/getting-started/quickstart/#tailwind-css-v3
Additionally: