Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (76d1ee5) to head (46050d4).

@@           Coverage Diff           @@
##           master    #8502   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4076     4076           
=======================================
  Hits         4040     4040           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Trying to understand how I had this deprecation message on my dev machine, does not seem to affect 8.0.0.beta1

Sorry, I can't replicate the deprecation but this commit should not hurt

@tagliala the reason is this was actually reverted in rails/rails@5c0b749 as I noticed from this rubocop-rails PR comment.

Thanks for noticing. I didn't see the revert PR linked to the PR I was taking a look to.

What should we do?

@tagliala the reason nothing was linked is that there was no PR. It was a revert commit that was pushed directly to the default branch. Hmm well it doesn't seem worth doing the change because there is no deprecation now. Reviewing other PR's following that, there was another revert as well. Rails is making changes to routing but seems to be scaled back a bit. I think we should ignore this for now and only make a change once we have deprecations from an official release. Thank you.