Skip to content

Disallow sqlite3 2.x #8318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tagliala merged 1 commit into from
May 2, 2024
Merged

Disallow sqlite3 2.x #8318

tagliala merged 1 commit into from
May 2, 2024

Conversation

@tagliala
Copy link
Contributor

@tagliala tagliala commented May 1, 2024 •
edited
Loading

Ref: rails/rails#51636

Not quite sure of this fix, especially on the dependabot side

@codecov
Copy link

codecov bot commented May 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (5e1a8d8) to head (883faf6).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8318   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files         140      140           
  Lines        4018     4018           
=======================================
  Hits         3982     3982           
  Misses         36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javierjulio
Copy link
Member

javierjulio commented May 1, 2024

@tagliala this would be right as I had to lock the version to v1 for the bug report template scheduled workflow for that test to pass. For the Dependabot config file change, wouldn't we want to duplicate that for the other bundler entries?

@javierjulio javierjulio mentioned this pull request May 1, 2024
Closed
@tagliala
Copy link
Contributor Author

tagliala commented May 1, 2024

For the Dependabot config file change, wouldn't we want to duplicate that for the other bundler entries?

Oh, thanks.

That's why I wasn't quite sure of this fix, because I didn't notice the other gemfiles. Will do the change (both here and on demo)

@javierjulio
Copy link
Member

javierjulio commented May 1, 2024

Ok great, thank you!

@tagliala tagliala force-pushed the chore/disallow-sqlite3-2 branch from 0b66cfb to 4cfb9ef Compare May 1, 2024 14:50
@tagliala tagliala force-pushed the chore/disallow-sqlite3-2 branch from 4cfb9ef to 883faf6 Compare May 1, 2024 14:52
tagliala
tagliala commented May 1, 2024
View reviewed changes
gemfiles/rails_70/Gemfile.lock
PLATFORMS
arm64-darwin-21
arm64-darwin-22
ruby
Copy link
Contributor Author

@tagliala tagliala May 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is being added by my local configuration. I have a global force_ruby_platform setting which is for some reason overriding the local .bundle/config

@tagliala
Copy link
Contributor Author

tagliala commented May 1, 2024

Supersedes #8315, #8316, #8320

javierjulio
javierjulio approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit 3e4b3cb into activeadmin:master May 2, 2024
@tagliala tagliala deleted the chore/disallow-sqlite3-2 branch May 2, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javierjulio javierjulio javierjulio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tagliala @javierjulio